In D8300#161302, @rkflx wrote:

Good job accepting this advice (which I agree with), such is not always easy :)

Thanks. I've understood my mistakes :)

In D8300#161302, @rkflx wrote:

You could use the "Abandon" state in this case.

Yep, just figured it out, that it is in the comments section :)

In D8385#161288, @rkflx wrote:

In D8385#161287, @lexdem wrote:

The main conversation happens in #kde-devel, right? Or there is chat in Phabricator too?

While Phab has a chat (icon right to the bell icon next to the Phab logo), it is not used as far as I know. Just use IRC, but there are also project specific mailinglists (e.g. okular-devel for Okular).

In D8385#161286, @rkflx wrote:

I had this already prepared (look at the commit timestamp), and scheduled for tomorrow. But if you want it now, you get it now :)

Thanks again for the patch, looking forward to more contributions. Just ask if you need ideas or help…

Week already passed? :) I just waiting to continue coding and still didn't ruin the workflow for this commit :)

In D8385#160109, @rkflx wrote:

So, if there are a lot of products with new features, they're bundled to some new version? Like from 16.12 to 17.04 . Is this also controlled by any kind of CI, to bundle them? Sorry, if I ask too much, I'm just curious about the whole process :)

You can look at the Annoucements to get a sense for what products KDE ships, what software those include and which changes are made. Note that these are time-based releases according to the Schedules, while other applications e.g. in Extragear have other release cycles, sometimes even feature-based like you were describing. See also here.

As for release automation, I believe right now this is a manual process with the help of some scripts (not sure how accurate, but this, R497 and R572 may give you some idea) and depending on product is done by the release team or the individual maintainers.

That said, you can also visit KDE's IRC channels to get questions answered in a more interactive fashion.

In D8300#159643, @cullmann wrote:

I don't think this is something more than a few people want and not worth the effort.

In D8300#158780, @cullmann wrote:

Hi, I am not sure this feature is that important to have.

If I read the feature request you linked correctly, what is implemented here is actually not that what is wanted there.

https://bugs.kde.org/show_bug.cgi?id=377538

looks more like one wants a fast way to create a snippet library.

Perhaps this would be more interesting as an snippet plugin extension to easily create new snippets for e.g. copyright headers
or default class declarations?

In D8300#158379, @sars wrote:

Hi,

Are you aware that dragging a selection to anywhere in kate, except the document view, will create a new file with the selection. But that requires mouse action....

In D8300#158141, @brauch wrote:

Hmm, I'm not sure -- this is quite a bit of code for a feature I personally wouldn't know how to make use of. Yes, I sometimes want to perform this action, but really, I just press Ctrl+C, Ctr+N, Ctrl+V and I have achieved the same thing -- and it's much easier to remember than another shortcut for specifically this ...

The implementation itself looks fine, I'm just unsure whether this necessitates a whole new plugin.

Thank you, I will wait for this :)

Yep, sorry. Fixed

In D8385#158072, @rkflx wrote:

In D8385#158066, @lexdem wrote:

@ngraham , changed to the "FEATURE"

You changed it to **FEATURE**, but the tooling handling this is not part of Phabricator and probably won't understand markdown. Could you change it to just FEATURE, please?

Hello. Have anyone found some errors? This patch exists over a week. I'm not saying, that I pressure anyone, I just afraid, if the version will increase in kateui.rc , the build could not pass. Could it be a problem? I mean, if there will be a patch which will increment the the number to 83, can this diff be passed?

@ltoscano , Thanks, got it. So, if there are a lot of products with new features, they're bundled to some new version? Like from 16.12 to 17.04 . Is this also controlled by any kind of CI, to bundle them? Sorry, if I ask too much, I'm just curious about the whole process :)

@rkflx , Thanks, that was exactly what I wanted to know about the processes in landing of patches here, in Phabricator :)

Ok, i got you. Let it be just this small :'D
P.S. about zoom. I will try to implement that ASAP.
P.P.S Could anyone link me to documentation of whole phabricator-distro process? I mean, which stages should pass the patch to be included in next update of Arch\Ubuntu?

In D8385#157503, @rkflx wrote:

Here is another idea which should accommodate the use case of the bug reporter (not sure how difficult this would be to implement, though):

In the Overview columns combobox, introduce an Auto mode, which depending on zoom level and window size dynamically adapts the number of columns from 1 to m, where 1 should still allow zooming in further and m is the maximum number of columns needed to fully show the complete set of pages. The upper limit for m would be the total number of pages in non-continuous mode, e.g. 1 for a single page document. This mode would basically correspond to the behaviour you get when zooming the thumbnails in "Adobe Reader" or "Foxit Reader".

This way, we would not change the behaviour of the static overview column modes. In contrast to the bug reporter, users might have use cases for not changing the column number automatically, i.e. keeping the page zoom constant.

---

Apart from that idea, I'd probably prefer the automatic reduction in columns over yet another config option.

In D8385#157468, @ngraham wrote:

1. The word "less" should be replaced with "fewer" in all the places where you've used it. Less is used for an indeterminate quantity (e.g. less rice, less water, less bad). Fewer is used for anything you can count (e.g. fewer columns, fewer people, fewer lines of code)
2. I'm not sure this makes sense as a user-configurable option. Why not just fix the use case outlined in the bug?

Renamed all occurrences of word "less"

One more i18n for better UX.

Added new lines to the end of files. Removed indentation

Removed unused commentary in headers.

In D8300#155456, @ngraham wrote:

Also, do we really need the Cut + new file version? Is the copy + new file version enough?

Changed the strings

In D8300#155434, @ngraham wrote:

! In D8300#155426, @lexdem wrote:
Changed. Sorry, couldn't take screenshot from "Edit" menu in Spectacle. IDK why, but it just don't capture the active popups :(

Yeah that's an X11 bug/limitation. The workaround is to open Spectacle, set it to take a screenshot in a few seconds, and then use that time to open the menu you want to screenshot.

There are a few typos in your Test Plan:

Don;t know, if it necessary -> I don't know if this is necessary

In D8300#155421, @ngraham wrote:

Thanks for the patch! Can you change the formatting here on Phabricator a bit?

• Title should be a short description of the actual feature
• Don't need FEATURE
• The bug number goes in the Summary section, like this: "BUG: 377538"
• Add some details about your testing to the Test Plan section
• Add some screenshots of the feature! This is always welcome for attracting reviewers. :)

Removed useless commentary

In D7848#146398, @aacid wrote:

I have to ask, i need your real name to give you proper copyright attribution and "Lex Dem" doesn't really look like a russian name, could you please confirm your real name?

In D7848#146378, @aacid wrote:

Did you upload a wrong diff?

Fixed wrong diff

Shortened from searching bookmark to just remove with viewport

Removed commented lines

removed typo in "rename"