Directly specify arcsecond error in Align UI.
ClosedPublic

Authored by murveit on Nov 2 2019, 8:11 AM.

Details

Summary

As part of the align tab, the user enters an accuracy (in arc-seconds) for the error tolerance
in pointing the telescope to the target, but the error value calculated is not currently reported
in the UI. What is currently reported is the DEC d-m-s arc-second difference, and the RA h-m-s
difference (which is not arc-seconds), not the combined arc-second difference.
With this change, the difference in arc-seconds (directly comparable to the user's specification),
followed by the RA and DEC arc-second differences are printed in the UI. It is printed in green
if the specification is met, and red if it is not met.
Screenshot of the UI.
https://drive.google.com/file/d/1EH51G3LosVIT9vLY3nIx1UpH7rsw7tj4/view?usp=sharing

Test Plan

Run alignment with debug output, see the arcsecond error printed to the debug log console,
note that the errors printed match the values printed in the new Err UI box in Align, and
note that the printing is in red if the error is greater than the tolerance specified in Align,
or printed in green if the error is less.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
murveit created this revision.Nov 2 2019, 8:11 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptNov 2 2019, 8:11 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
murveit requested review of this revision.Nov 2 2019, 8:11 AM

Ok that makes sense. But we only have two states? green and red? I though we also have a "warning zone" as well in the graph?

Note sure I agree, but would be happy to add a color if you felt strongly about it. It seems like anything at or below the Accuracy spec should be green. I could add a yellow, but in what range would you recommend? Twice the accuracy? Within 1 arc-minute? ...

I found in the code that you have a yellow region between 1.0 and 1.5 x the accuracy threshold.
I'll modify it to do that.

murveit updated this revision to Diff 69184.Nov 2 2019, 9:06 AM

The error is printed in yellow if it is between 1 and 1.5X the accuracy tolerance.

@lancaster What do you think?

I like it, this is a great idea!

mutlaqja accepted this revision.Nov 3 2019, 2:39 PM
This revision is now accepted and ready to land.Nov 3 2019, 2:39 PM
This revision was automatically updated to reflect the committed changes.