Differential D25376

Load PHD2 star image from memory instead of temporary file
ClosedPublic
Actions

Authored by jarnopaananen on Nov 18 2019, 6:34 PM.

Details

Reviewers
lancaster
mutlaqja
Commits
R321:d6a60f19db8b: Load PHD2 star image from memory instead of temporary file
Summary

Currently Ekos saves the JSON formatted star image to temporary FITS file and loads it back, but CFitsio also supports simple memory file system that can be used instead saving writes to disk. Also reduces log spam as there is a debug print about each FITS load if debug logging is active.

Test Plan

Use PHD2 as usual and observe star images still being shown.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jarnopaananen created this revision.Nov 18 2019, 6:34 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptNov 18 2019, 6:34 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
jarnopaananen requested review of this revision.Nov 18 2019, 6:34 PM
jarnopaananen updated this revision to Diff 69948.

Added free() calls to error paths.

mutlaqja accepted this revision.Nov 18 2019, 6:45 PM

A very welcome change! The less we access disk, the better it is.

This revision is now accepted and ready to land.Nov 18 2019, 6:45 PM
lancaster accepted this revision.Nov 18 2019, 8:47 PM

This appears to work very well! Great work!

Closed by commit R321:d6a60f19db8b: Load PHD2 star image from memory instead of temporary file (authored by mutlaqja). · Explain WhyNov 19 2019, 5:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 69968

View Options

kstars/ekos/guide/externalguide/phd2.cpp

Loading...