Shouldn't the screenshots show english text for consistency?

Imo KMessageWidget should not rely on being placed where there's enough contrast. The transparency just doesn't work in the case of Konsole.
Either Konsole needs to move the widget outside the terminal painting area which looks complicated to achieve or the message widget should provide some API
which apps can use in cases where the background has not enough contrast.

Big +1

This change makes D10983 more relevant.

Don't hide disabled actions

In T7914#127190, @mmustac wrote:

I can't help me but I have some trouble to unterstand the privacy issue which comes up every time when such a topic gets discussed.
Okay I can imagine ehy it can be a privacy issue but then it would mean thaht the the background itself is one. So lets say I am sitting with my notebook on some public place like the airport und someone looks over my shoulder then he other peobple walking by can see my wallpaper too (if there are no maximized windows of course).
So privacy issue = yes but not only a problem of the login/lock-screen.

@ach Thanks for bringing this up. Found a way better approach. Will create a new revision for it.

In D10935#223346, @ach wrote:

In case it's not hidden, but destroyed, create a new KMessageWidget?
Or maybe the 'close' button can be remapped to trigger a hide instead of destroy?

In D10935#223341, @ach wrote:

Other apps (dolphin, kmail) use the 'cross on red bg' button in the upper right corner to close the msg.

I think that is much more intuitive and consistent (and shorter) than having a 'close' URL in the ever changing text formulations like 'Please click _here_' or '_Dismiss_' or ...

If you want I can submit a proper bug for this.

In D10935#220359, @hindenburg wrote:

If the "output has been suspended" is active and that tab is dnd to create another window, the kmessage is not shown and it seems to take an extra Ctrl+q to get the tab to resume.

In D10935#220065, @hindenburg wrote:

Can you redo this patch so it apples cleanly to master?

Rebase on master

Explicit nullptr check

In D10862#218315, @hindenburg wrote:

Thanks, overall I don't see any major issues.

There are some issues below which I don't think should hold up committing this. Perhaps later you could work on them if you're interested.

1. dbus methods still work on locked tabs: example qdbus $KONSOLE_DBUS_SERVICE /Sessions/3 sendText hi
2. Certain menus should be disabled on locked tabs: (right click menu) Switch Profile, * Scrollback, Rename(?). Split View..... and more...

Removed unrelated code

@ngraham No, I don't think so. This one here doesn't work without the other one.

• Read-only flag is now part of the Session and thus moving / detaching a tab won't remove it
• Change tab icon when read-only
• Add action to tab context menu
• Bumped rc version

In D10983#217858, @hindenburg wrote:

What version are you using? It works here showing the prompt.

In D10862#216038, @hindenburg wrote:

1. You have to increase the *rc version or the new files don't get installed

Just bumping is enough, right. Noted.

In D10862#215637, @ngraham wrote:

With the move to KMessageWidget, let's make sure we don't regress anything: in those screenshots the widget is overlapping the scrollbar and presumably the top few lines of text too. We'll need to fix those issues.

In D10862#215452, @hindenburg wrote:

I have code that changes that label to a kmessagewidget; the changes were so small that I haven't bothered committing.

And you'll have to allow the possibility of having both visible at the same time.

I'll look at the code later this week

In D10862#214408, @ngraham wrote:

Putting on my VDG hat: we definitely need a visible UI during read-only mode that tells you that the terminal is read-only, or else there is a near-100% chance that people will file bugs after they turn on read-only mode by accident or forget that it's on.

Konsole already shows a yellow-colored contextual bar that appears near the top of the window in various other contexts; maybe we could re-use that here?

I agree, the context menu looks really convoluted. But what happens when the cashew is disabled and the desktop is empty? There would be no way to add widgets.