Keep suspended mode message after tab detach
Needs ReviewPublic
Actions

Authored by jnoack on Mar 9 2018, 10:33 PM.

Details

Reviewers

Group Reviewers

Summary

When a tab is suspended (CTRL+S) and gets detached, the messagewidget is not
restored. To fix this the detached view is also passed down to the ViewManager, so
that the ViewManager can apply the correct state for the new view.

Test Plan

Suspend tab with CTRL+S
Detach tab
MessageWidget still visible

Diff Detail

Repository

R319 Konsole

Branch

keep-suspended-mode-after-detach

Lint

No Linters Available

Unit

No Unit Test Coverage

jnoack created this revision.Mar 9 2018, 10:33 PM

Restricted Application added a project: Konsole. · View Herald TranscriptMar 9 2018, 10:33 PM

Restricted Application added a subscriber: Konsole. · View Herald Transcript

jnoack requested review of this revision.Mar 9 2018, 10:33 PM

hindenburg added reviewers: Konsole, hindenburg.Mar 10 2018, 9:26 PM

That's a lot more complex than I expected. Since this has always been like this, I'm not concerned about getting it in 18.04

Revision Contents
Changeset List

			Path	Packages
M			src/Application.h (3 lines)
M			src/Application.cpp (5 lines)
M			src/MainWindow.h (5 lines)
M			src/MainWindow.cpp (5 lines)
M			src/ViewManager.h (8 lines)
M			src/ViewManager.cpp (25 lines)