It clutters the UI and can still be permanently enabled in settings if so desired.
Details
- Reviewers
mart hindenburg - Group Reviewers
VDG - Commits
- R319:7f8baec6055e: Default to show tab bar only when needed
Konsole looks a lot cleaner out of the box now
Diff Detail
- Repository
- R319 Konsole
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
That screenshot is not the default correct? The menubar is shown by default. I don't like the 'ShowWhenNeeded' but I don't really have an opinion on the default.
Especially since the menu bar is always visible by default (to make sure that tab functionality remains discoverable), I think this is fine.
I thought this change here is about making it the tab bar not visible by default.
EDIT: To expand upon this: when Konsole is executed there is only one tab open, so the tab bar would not be visible with the setting ShowTabBarWhenNeeded as default. Only after the user has opened a second tab through some means it would show the tab bar again.
Right, @hindenburg and @ngraham were talking about the menu bar, which is probably not shown in the screenshot because @broulik was using the menu in window decoration button.
I'm against this change here because it makes tab functionality more difficult to discover (through the menu). When there is a tab bar at the bottom it's obvious that you can open another tab through some means. In the screenshot it looks better without the tab bar though, that's for sure (although we normally still have window frames as default, don't we?).
Sorry for the confusion, I am using title bar menu button which is why the menu isn't shown. This patch is *only* about the tab bar.
Konsole is an app for Expert users, so I don't think not showing the tab bar by default is a problem. Experts know about tabs, use menus, use keyboard shortcuts, etc. And they typically really appreciate clean design. I anticipate that we will get some good press from design-ey polish changes like this. +1 from me.
i think the patch is fine... tough conflicts a bit in combination with the option i use that shows the new tab button in the tabbar.. tough i can live with that
Expert users don't start out being experts, they start out as beginners and then maybe become experts later on. IMHO, defaults really cater more to beginners than to experts (who know how to customize the tools they've used on a daily basis for quite some time). Discover-ability matters to first-time users.
I'm not talking about users who are Konsole experts, I'm talking about users who are Experts in a general sense: "Expert" with a capital E. i.e. people whose user profiles involve using menus, keyboard shortcuts, and the command line; looking for and using configure windows; understanding tabbed interfaces, etc. I 100% agree with you that good defaults are for beginners. But even a Konsole beginner is already an Expert user almost by definition, since terminal apps are (or should be) for Expert users only.
For reference, GNOME-terminal and macOS terminal hide the tab bar by default, and don't seem to suffer any usability-related headaches as a result. Again, people who use Konsole are Experts will appreciate this aesthetic improvement and have no difficulty using tabs if desired.