Differential D11241

Use default close button of KMessageWidget
ClosedPublic
Actions

Authored by jnoack on Mar 11 2018, 6:22 PM.

Details

Reviewers
ach
hindenburg
Group Reviewers
Konsole
Commits
R319:c442d223138f: Use default close button of KMessageWidget
Summary

D10935 introduced KMessageWidgets in TerminalDisplay for the "resume"
and "read-only" messages. This patch restores the default close button
and makes use of animateShow/animateHide. A nice plus is that I also
removed some code which has become obsolete AND that the messages
are now animated.

Test Plan

Show/hide works like before.
Also still works if readonly and suspended at the same time.
Detaching works.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jnoack created this revision.Mar 11 2018, 6:22 PM
Restricted Application added a project: Konsole. · View Herald TranscriptMar 11 2018, 6:22 PM
Restricted Application added a subscriber: Konsole. · View Herald Transcript
jnoack requested review of this revision.Mar 11 2018, 6:22 PM
jnoack edited the summary of this revision. (Show Details)Mar 11 2018, 6:23 PM
hindenburg added reviewers: Konsole, hindenburg.Mar 11 2018, 6:49 PM
hindenburg added a subscriber: hindenburg.

please put Konsole as reviewers - other wise it won't show up in https://phabricator.kde.org/project/37/item/view/637/

hindenburg accepted this revision.Mar 11 2018, 10:44 PM
hindenburg retitled this revision from TerminalDisplay: Use default close button of KMessageWidget to Use default close button of KMessageWidget.
hindenburg edited the summary of this revision. (Show Details)

Thanks - a much cleaner approach

This revision is now accepted and ready to land.Mar 11 2018, 10:45 PM
Closed by commit R319:c442d223138f: Use default close button of KMessageWidget (authored by jnoack, committed by hindenburg). · Explain WhyMar 11 2018, 10:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/TerminalDisplay.h (4 lines)
Msrc/TerminalDisplay.cpp (34 lines)

Diff 29293

View Options

src/TerminalDisplay.h

Loading...
View Options

src/TerminalDisplay.cpp

Loading...