Disable menu actions when read-only/locked
ClosedPublic
Actions

Authored by jnoack on Mar 14 2018, 9:54 PM.

Details

Reviewers

Group Reviewers

Commits

R319:3a1d350b6742: Disable menu actions when read-only/locked
R319:429ad275d95f: Disable menu actions when read-only/locked

Summary

This patch addresses the following points:

Ignore most DBus methods
Disable the following actions:

clear-history, clear-history-and-reset, edit-current-profile, switch-profile
adjust-history, send-signal, zmodem-upload, edit-rename (tab bar)

Session updates all views correctly when readonly changes

Test Plan

Actions do not show when locked
DBus methods are ignored when locked
Multiple views in one session get correctly updated

Diff Detail

Repository

R319 Konsole

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

jnoack created this revision.Mar 14 2018, 9:54 PM

Restricted Application added a project: Konsole. · View Herald TranscriptMar 14 2018, 9:54 PM

Restricted Application added a subscriber: Konsole. · View Herald Transcript

jnoack requested review of this revision.Mar 14 2018, 9:54 PM

jnoack edited the summary of this revision. (Show Details)Mar 14 2018, 9:55 PM

jnoack added a reviewer: Konsole.

I'd rather they menu items were disabled - not removed.

I think almost all under Edit and View menus should be disabled.

Should you be allowed to close a read-only tab?

EDIT: +1 for disabling rather than hiding the affected menu items.

If you hide all the menus the UI will look quite a bit different and IMHO confusing to the use. When disabled, the user knows they menu items are there but can't be used ATM.

I'm sorry, I wrote my comment backwards. I agree with you, Kurt: +1 for disabling rather than hiding.

Don't hide disabled actions

hindenburg retitled this revision from Konsole: Disable more actions when locked to Disable menu actions when read-only/locked.Mar 20 2018, 12:42 AM

hindenburg edited the summary of this revision. (Show Details)

thanks

This revision is now accepted and ready to land.Mar 20 2018, 12:45 AM

Closed by commit R319:3a1d350b6742: Disable menu actions when read-only/locked (authored by jnoack, committed by hindenburg). · Explain WhyMar 20 2018, 12:45 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/Session.h (3 lines)
M			src/Session.cpp (29 lines)
M			src/SessionController.h (3 lines)
M			src/SessionController.cpp (60 lines)
M			src/TerminalDisplay.h (3 lines)
M			src/TerminalDisplay.cpp (18 lines)
M			src/ViewContainer.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	29533	7f8baec		Mar 14 2018, 9:54 PM	★	★
Diff 2	29605	6992751	Don't hide disabled actions	Mar 15 2018, 3:40 PM	★	★
Diff 3	29958	fc5ffe6	R319:3a1d350b6742bfd673f10f7a1f0957e9f4d95ed5	Mar 20 2018, 12:45 AM	★	★