Differential D4747

Rework of size/space calculation
ClosedPublic
Actions

Authored by abika on Feb 23 2017, 4:04 PM.

Details

Reviewers
martinkostolny
janlepper
Group Reviewers
Krusader
Commits
R167:286a2d224fd1: FileSystem: added new SizeCalculator class for async calculation of space
R167:03ec7300fb20: VFS: calculate space with KIO on non-local fs is working now
R167:fb88b8994ca8: VFS: removed custom calc space on local fs using Qt, slower than KIO
R167:03e9a2ccd20e: Archive: own method for counting files before packing
R167:bbe7221e6f22: Merge branch 'my-calc_space'
R167:214bb19adeaa: FileSystem: removed unused space calculation in FileSystem
R167:83d3b67274b2: Panel: Replaced space calculation in KrCalcSpaceDialog with SizeCalculator
Summary

Added:

  • support for size calculation on all KIO protocols + virtual fs
  • size calculation now unblocking

Removed:

  • Size calculation with space key. Selecting+shortcut works just as well. This mode was blocking, flashing dialog was possible and end result with number of files/folders was not visible. No advantages over using the "calc space" action
Test Plan

Tested on local, ftp, virt filesystem with dirs (recursive) and files.
Tested changing directory panel/closing panel during calculation.

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abika created this revision.Feb 23 2017, 4:04 PM
janlepper accepted this revision.EditedFeb 27 2017, 8:51 AM
janlepper added a subscriber: janlepper.

Very nice!
As a next step, if I didn't miss anything, calcSpaceFileSystem in AbstractJobThread::countLocalFiles() could be removed.
The packjob should be passed a list of URLs instead of file names which would eliminate the need to determine the URLs.

This revision is now accepted and ready to land.Feb 27 2017, 8:51 AM
martinkostolny accepted this revision.Feb 27 2017, 4:07 PM
martinkostolny added a subscriber: martinkostolny.

Perfect, Alex, thanks! :)

abika added a comment.Feb 27 2017, 4:31 PM

Thanks!

As a next step, if I didn't miss anything, calcSpaceFileSystem in AbstractJobThread::countLocalFiles() could be removed.
The packjob should be passed a list of URLs instead of file names which would eliminate the need to determine the URLs.

Yes, I left this because I didn't want to touch too much. And `downloadIfRemote() seems to be broken, too.

Closed by commit R167:03ec7300fb20: VFS: calculate space with KIO on non-local fs is working now (authored by Alexander Bikadorov <alex.bikadorov@kdemail.net>). · Explain WhyFeb 27 2017, 4:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11906

View Options

krusader/FileSystem/filesystem.h

Loading...
View Options

krusader/FileSystem/filesystem.cpp

Loading...