Fix runes parsing.
ClosedPublic
Actions

Authored by ematirov on Jun 13 2017, 4:59 PM.

Details

Reviewers

apol
brauch

Commits

R59:8575b935f2ad: Fix runes parsing.

Summary

Do not parse ''' as valid rune.
Fix duplicates in runes test: '\'' is same as '''. Add '\\'' instead.

Test Plan

Tests pass.

Repository

R59 KDevelop Go

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

looks good

parser/test/parsertest.cpp
136	intentional?

This revision is now accepted and ready to land.Jun 13 2017, 5:53 PM

parser/test/parsertest.cpp
136	Yep, if token could not be parsed it ends up with "Token_TEST" as far as I understood. So, there is verification that ''' is not parsed (because it's not valid go code)

parser/test/parsertest.cpp
124–125	Shouldn't the TODO be fixed then?
128	Maybe as part of another iteration, but this should better be: `QCOMPARE( lexer.read().kind, TokenTypeWrapper::Token_RUNE);`

Remove unneeded comment.

parser/test/parsertest.cpp
128	Good idea. I will fix that in another RR since there are a lot of such QVERIFY misuses in that file (not related to this test\change)

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			parser/go.g (3 lines)
M			parser/test/parsertest.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15432	835337d		Jun 13 2017, 4:57 PM	★	★
Diff 2	15447	835337d		Jun 14 2017, 12:17 PM	★	★
Diff 3	15527	5500d0d	R59:8575b935f2adeb170528d91229a7f0c5455bb418	Jun 17 2017, 4:14 PM	★	★