Removed duplicated code related with item icon

Added a new role to access icon name property

Fixed code style
Added more unit test

Used convertedUrl from KFilePlacesModel insted of implement a new one

Renamed function from convertUrl to convertedUrl

Created new function convertUrl
Added @since tag to new functions

Updated parent branch

Use a new function to avoid duplicated code

Fix group types to support new types.

Fixed code style

Fixed code style

Rollback unecessary changes
Added functions documentation

Still some code cleanup to do and tests to run.

Updated unit test

• Use Kio::KPlacesModel as source model for PlacesItemModel

Removed commented code

Created more unit tests

Updated parent branch

Updated parent branch

Make 'isFileIndexingEnabled' a static function

Updated parent branch

Update device info if udi changes.

In D8348#167924, @mwolff wrote:

In D8348#163546, @ngraham wrote:

Could you add camera:/ devices to this section too? That way we could also take care of https://bugs.kde.org/show_bug.cgi?id=386060

this isn't done yet, I think

Updated parent branch

Updated parent branch

Fallback to initial url if the searchUrl is invalid.

Fixed typos

Parent branch update

Fixed import

Updated parent branch

Updated parent branch

Added warning message for invalid search:// urls

rebase from origin

Update unit test

In D8366#163427, @ngraham wrote:

Is this dependent on any of the other patches floating around?

Updated parent branch

Updated parent branch

Fixed code style

Fixed code style

Added more test cases
Renamed enum to match group name

Created unit test for remote ulrs

In D8434#162786, @mwolff wrote:

Well, but if we use Network for remote:// already, then the group should also have this label, no? I don't see an issue with this, really. On the contrary - maybe we could in the future remove the remote:// link and let the category header react to a click, such that it will show you e.g. all remote devices. That would remove the duplication then.

Renamed section from 'shared' to 'remote'

In D8434#162727, @mwolff wrote:

lgtm overall. but I wonder about the naming choice. "Shared" is confusing, to me personally at least. Why not call it "Remote" or "Network"? The reasoning is that "shared" for me is only LAN/WLAN shared stuff, while "remote://" allows arbitrary remote links. I use it to connect via (S)FTP to machines on the internet e.g.

In D8367#162465, @ngraham wrote:

Nice! If possible, I'd like a more user-friendly way of hiding and showing categories, though. The context menu is not very discoverable, and if a category is hidden, there's no indication that there's even anything to show. Here's how macOS finder handles this, for comparison (it's an animated gif; click to see it):

I Think we should keep the headers visible so users know that there are hidden sections.

For a show/hide UI, here are some ideas:

1. Add disclosure triangles to the right of the headers that, when clicked, hide the contents
2. On hover, the headers could gain an outline like a button and the text would change to "Show/hide [category]"; when clicked, it would hide the contents

Updated parent branch

Update parent branch

Created unittest for PlacesView::convertUrl
Refactory some small part of the code

Updated parent branch

Use plural form for RemovableDevicesType enum

Updated parent branch

Updated parent branch

Updated parent branch

Updated visuals to match dolphin

Guys, is that ready? Do you need any other change/fix?

Updated parent branch

Used new connect API

Pleas unit test "hiddenCount" when groups are invisible, it is used by the view in D8450

Used QLatin1String for static strings

Updated parent branch

Updated parent branch

Upated parent branch

Fixed typo

In D8433#158886, @ngraham wrote:

Looks like this was opened by accident; can you abandon it?

In D8433#158886, @ngraham wrote:

Looks like this was opened by accident; can you abandon it?