Feed Advanced Search

Jan 31 2020

vhanda added a comment to D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call.

Sorry. I'm removing myself as a reviewer. I barely remember this code base. It has been way too many years.

Jan 31 2020, 9:29 PM · Plasma
vhanda removed a reviewer for D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call: vhanda.
Jan 31 2020, 9:28 PM · Plasma

Jan 16 2018

vhanda added a comment to D9712: balooctl status: translatable message.

May I observe that relying on the command line output is fragile in the best case?
Unless the command can produce the output in some formatted way (like the openstack CLI, which can enable a special mode to produce output in various formats like csv, table-formatted, or direct values, and select the columns).

Jan 16 2018, 12:27 PM · Frameworks

Nov 27 2017

vhanda added a comment to D8007: popplerextractor: don't try to guess the title if there isn't one..

To give some history - Strigi used to do this guessing, and when I implemented KFileMetaData, I decided to do the same. I don't have an opinion on whether it is a good idea or not.

Nov 27 2017, 2:45 PM · Baloo, Frameworks
vhanda added a comment to D8007: popplerextractor: don't try to guess the title if there isn't one..

@vhanda do you know if there is something to do to update Baloo database when metadata returned by KFileMetaData are changed even if the file itself did not change ?

Nov 27 2017, 2:43 PM · Baloo, Frameworks

Oct 29 2017

vhanda accepted D8527: Display "Downloaded From" by default, if file supports it.

Looks good.

Oct 29 2017, 5:06 AM · Dolphin
vhanda added a comment to D8528: Consider DjVu files to be documents.

Since I was added as a reviewer, I thought I'll comment.

Oct 29 2017, 5:04 AM · Frameworks

Sep 16 2017

vhanda committed R293:6945d356ef21: Consider markdown files to be Documents (authored by vhanda).
Consider markdown files to be Documents
Sep 16 2017, 4:28 PM

Aug 8 2017

vhanda committed R32:f3c41d355512: Add a button to delete sessions in the SessionChooserDialog (authored by vhanda).
Add a button to delete sessions in the SessionChooserDialog
Aug 8 2017, 4:14 PM

Apr 11 2017

vhanda removed a reviewer for D5337: Corrects number of parameters for qml function flick.resizeContent in ImageBrowser.qml: vhanda.
Apr 11 2017, 10:45 AM

Mar 19 2017

vhanda accepted D4995: Fix DB inconsistency due to some docterms appearing with uppercase symbols.

This is awesome. Good work.

Mar 19 2017, 11:02 AM · Frameworks

Mar 3 2017

vhanda added a comment to D4911: add Baloo DBus signals for moved or removed files.

I'm not the maintainer of Baloo any more, so I don't want to give it a clear Yes / No.

Mar 3 2017, 11:37 PM · Baloo, Frameworks

Nov 8 2016

vhanda committed R226:b436775e5084: Merge branch 'nepomuk/tagsKioSlave' (authored by vhanda).
Merge branch 'nepomuk/tagsKioSlave'
Nov 8 2016, 12:38 PM
vhanda committed R226:747d3aaa7b0a: Merge branch 'nepomuk/megerRefactoring' (authored by vhanda).
Merge branch 'nepomuk/megerRefactoring'
Nov 8 2016, 12:38 PM
vhanda committed R226:2d7221ecd211: Merge branch 'nepomuk/resourceWatcher' of git://anongit.kde.org/kde-runtime… (authored by vhanda).
Merge branch 'nepomuk/resourceWatcher' of git://anongit.kde.org/kde-runtime…
Nov 8 2016, 12:38 PM
vhanda committed R226:3e449633089e: Merge branch 'nepomuk/strigiMultiProcess' (authored by vhanda).
Merge branch 'nepomuk/strigiMultiProcess'
Nov 8 2016, 12:38 PM

Aug 10 2016

vhanda accepted D2395: [Milou] Optimize and cleanup sources model.

Looks good.

Aug 10 2016, 7:51 PM · Plasma

Mar 20 2016

vhanda added a comment to D1185: drkonqi mappings: Move baloo_file* to "frameworks-baloo|Baloo File Daemon".

A big -1 from me. This is going to affect users with the most recent version of Plasma, which means previous versions will still keep filing bugs against Baloo. If anything, "frameworks-baloo" should be deleted. It's too late to change the product name.

Mar 20 2016, 8:32 PM · Plasma

Feb 5 2016

vhanda accepted D908: [Baloo Runner] Add mime data to matches.

I'm guessing this is for drag and drop.

Feb 5 2016, 1:44 PM · Plasma

Aug 7 2015

vhanda committed R22:ffc191751be6: Code cleanup (authored by vhanda).
Code cleanup
Aug 7 2015, 10:11 AM
vhanda committed R22:d3040600921e: Faster Implementation of AbstractMetadataModel::propertyUrl (authored by vhanda).
Faster Implementation of AbstractMetadataModel::propertyUrl
Aug 7 2015, 10:11 AM
vhanda committed R22:aeeb4168c936: Fix creation of bookmark resources (authored by vhanda).
Fix creation of bookmark resources
Aug 7 2015, 9:55 AM
vhanda committed R22:5c9c3172b158: Remove double "bookmark.h" include (authored by vhanda).
Remove double "bookmark.h" include
Aug 7 2015, 9:55 AM
vhanda committed R22:447b544b66e2: disable deprecated libnepomuk stuff for less compiler warnings (authored by vhanda).
disable deprecated libnepomuk stuff for less compiler warnings
Aug 7 2015, 9:54 AM
vhanda committed R22:c8594497ade1: Donot build the PIMO, NCO, NFO and NAO ontologies (authored by vhanda).
Donot build the PIMO, NCO, NFO and NAO ontologies
Aug 7 2015, 9:54 AM
vhanda committed R20:58bc75eef418: Add KRunner to the top of the homescreen (authored by vhanda).
Add KRunner to the top of the homescreen
Aug 7 2015, 9:51 AM
vhanda committed R20:c94b6c348ce4: Remove packaging for RPM (authored by vhanda).
Remove packaging for RPM
Aug 7 2015, 9:51 AM
vhanda committed R20:724389fac4ab: Remove the compositor (authored by vhanda).
Remove the compositor
Aug 7 2015, 9:51 AM
vhanda committed R20:25ae67d782af: Add README file for the systemd unit files (authored by vhanda).
Add README file for the systemd unit files
Aug 7 2015, 9:51 AM
vhanda committed R20:df0fd34bc1db: Rename satellite to plasma.phone (authored by vhanda).
Rename satellite to plasma.phone
Aug 7 2015, 9:51 AM
vhanda committed R26:4e402cd46907: Export the entire HOME folder instead of individual folders (authored by vhanda).
Export the entire HOME folder instead of individual folders
Aug 7 2015, 9:19 AM
vhanda committed R26:9005ca134f76: Temporarily disable check for ubuntu-greeter (authored by vhanda).
Temporarily disable check for ubuntu-greeter
Aug 7 2015, 9:19 AM

May 21 2015

vhanda committed R6:a8708aec58c1: Fix pkg-config library name (authored by vhanda).
Fix pkg-config library name
May 21 2015, 3:33 PM