BUG: 369195
Based on the Wikipedia page (https://en.wikipedia.org/wiki/DjVu), it seems reasonable to consider DjVu files to be documents rather than images.
vhanda | |
rkflx |
Frameworks |
BUG: 369195
Based on the Wikipedia page (https://en.wikipedia.org/wiki/DjVu), it seems reasonable to consider DjVu files to be documents rather than images.
Tested in KDE Neon. Compiled and deployed fine. .djvu files are now listed as Documents:
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
General sentiment makes sense, most DjVu documents I've seen were more like books. However, see inline comment. (Someone with actual mimetype or baloo knowledge should approve, though.)
didn't crash baloo with basic usage
If you don't have a DjVu file, that's not "basic usage", but "no usage", making it quite pointless to mention the absence of crashes :)
Anyway, see last section here for some example files: http://www.djvu.org/resources
I guess you need to edit your test plan again…
src/file/basicindexingjob.cpp | ||
---|---|---|
219 | Looking at /usr/share/mime/image, I see:
…and that's also what Dolphin shows. Probably best to add +multipage here? | |
220 | Is x-djvu a thing? Not sure, that's why I'm asking. |
Actually we don't need the xml extension here
src/file/basicindexingjob.cpp | ||
---|---|---|
220 | https://www.cuminas.jp/docs/djvuplugin/en_us/Content/MIME%20Types.htm said that it was an older one, so I figured I'd add that one for maximum compatibility. I can remove it if you want. |
src/file/basicindexingjob.cpp | ||
---|---|---|
219 | Sorry, with "add +multipage" I meant to add exactly this to the existing line, not to add an additional line. This way, "image" DjVu files are still classified as images by baloo, just as in Dolphin. This might be inconvenient in some cases, but that's how the mimetype standard defines it. | |
220 | Latest news from djvu.org is from 2013, "older versions of the DjVu Browser Plug-in" are probably even more prehistoric and won't run in upcoming browsers anyway. I don't have this on Tumbleweed, if your Kubuntu does not have it I would tend to removal. Also I believe this is just for opening files in the browser and not relevant to indexing at all. |
Only mark multipage DjVu files as documents, and remove crufty old compatibility mimetype that's probably not relevant at all
Since I was added as a reviewer, I thought I'll comment.
I am not currently maintaining Baloo or using it, so I don't want to really discuss the specifics. Though from a technical point of view this change will work. If nobody has any objections, I would say go for it.
I'd say this can land. Perhaps best to wait until Monday evening, so Frameworks people not spending their weekend at the computer have a chance to weigh in?