[Milou] Optimize and cleanup sources model
ClosedPublic

Authored by broulik on Aug 10 2016, 2:30 PM.

Details

Summary
  • Simplify queryString once, rather than during every iteration
  • Foreach instead of potentially detaching range-for
  • Use reverse iterators (new in Qt 5.6) instead of Java-style iterators
  • Remove traces of begin/endInsert/RemoveRows feature - while it would be nice to not reset the model with all this sorting and merging going on it's pretty difficult to predict where an item will end up which is probably why it never got implemented. It still calculated tons of indices that went unused, so remove this and go a different route in the future
Test Plan

Seems to work

Diff Detail

Repository
R112 Milou
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 5810.Aug 10 2016, 2:30 PM
broulik retitled this revision from to [Milou] Optimize and cleanup sources model.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, vhanda.
broulik set the repository for this revision to R112 Milou.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 10 2016, 2:30 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
vhanda accepted this revision.Aug 10 2016, 7:51 PM
vhanda edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Aug 10 2016, 7:51 PM
This revision was automatically updated to reflect the committed changes.