• Simplify visible binding

• Do not implicitly convert float to bool

• Use "edit-clear-locationbar-{rtl,ltr}" as icon to match widgets style

Note that https://bugzilla.opensuse.org/show_bug.cgi?id=1152638 says pcap_breakloop() is unsupported when called from multiple threads. However, the actual libpcap documentation states:

I went over it again and found a few more small things and also added some suggestions. Feel free to apply or ignore the suggestions. Once the other items have been taken care of, I think this is good to go.

KAuth has a parentWidget property for actions (https://api.kde.org/frameworks/kauth/html/classKAuth_1_1Action.html#af91c15e1de114497e20e5c391f2afc3e) that is used to set window modality, it can probably do with just a QWindow.

• Remove Component {} wrapping for Component properties

That's correct. The reason for that is that a non-root process is not allowed to read which inodes root process has open, thus there is no way for the helper to map from incoming port to process ID. The only way I know of solving that is by having the helper run as root, which I would prefer to avoid.

The readme already mentions it needs cap_net_raw. But I've now added a line on how to ensure that it has that.

• Add a line that explains using setcap for cap_net_raw

• Address review comments

I have probably missed stuff, but here are my initial comments.

• Remove usage of no longer existing property

• Fix null object error

• Use libexec dir for the helper install location
• Don't use nonexistant variables

• Reject lines <7 elements instead of <2

• Add missing header and remove unneeded forward declares
• Code style fixes

Just a few small things I came across when working on the network plugin.

Just a small thing I noticed when scrolling through the patch.

Right, so leave it to application users how to deal with that, maybe later on add some convenience functions. Sounds sensible. :)

T6133 suggests that tags are formatted as "group##key=value" or something similar. Wouldn't it make sense to handle parsing that format here as well? Or are tags more intended as exact matches?

• Change ContentList::data back to single return point
• Fix FileSystem searcher when locations is not set
• Properly perform mime-type filtering in Baloo searcher
• Use the right role from ContentList for retrieving the file path
• Simplify if statement in ContentList::componentComplete