Remove custom content item from ActionMenu separator

Authored by ahiemstra on Sep 8 2019, 8:45 AM.



Since MenuSeparator is properly styled by QQC2 Desktop Style these days,
there is no need for custom styling here. In addition, it actually leads
to incorrect results.



Test Plan

Run a Kirigami application with a Menu with a separator. Observe that it
works correctly.

Diff Detail

R169 Kirigami
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Sep 8 2019, 8:45 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptSep 8 2019, 8:45 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Sep 8 2019, 8:45 AM
ahiemstra edited the summary of this revision. (Show Details)Sep 8 2019, 8:48 AM
ngraham accepted this revision.Sep 8 2019, 9:42 AM
This revision is now accepted and ready to land.Sep 8 2019, 9:42 AM
apol added a subscriber: apol.Sep 8 2019, 9:46 AM

Other than that, LGTM +1


I don't think the Component {} wrapping is necessary.

ahiemstra updated this revision to Diff 65647.Sep 8 2019, 12:18 PM
  • Remove Component {} wrapping for Component properties
ahiemstra marked an inline comment as done.Sep 8 2019, 12:19 PM
ahiemstra added inline comments.

You are right, it is not needed. I have also removed it from itemDelegate.

This revision was automatically updated to reflect the committed changes.