Since MenuSeparator is properly styled by QQC2 Desktop Style these days,
there is no need for custom styling here. In addition, it actually leads
to incorrect results.
Before:
After:
mart | |
ngraham |
Kirigami |
Since MenuSeparator is properly styled by QQC2 Desktop Style these days,
there is no need for custom styling here. In addition, it actually leads
to incorrect results.
Before:
After:
Run a Kirigami application with a Menu with a separator. Observe that it
works correctly.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Other than that, LGTM +1
src/controls/private/ActionsMenu.qml | ||
---|---|---|
31–32 | I don't think the Component {} wrapping is necessary. |
src/controls/private/ActionsMenu.qml | ||
---|---|---|
31–32 | You are right, it is not needed. I have also removed it from itemDelegate. |