- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Nov 15 2018
Nov 12 2018
Can I push it now to the master?
- Remove some dynamic casts
Nov 9 2018
Nov 6 2018
Nov 5 2018
Nov 1 2018
Oct 29 2018
In D16397#349121, @nmel wrote:Also, summary is incorrect:
This is just the fist part, more will follow.
Fixed missing this pointer in lamba call.
Oct 26 2018
Oct 24 2018
I have realized now that used lambdas in two ways, with and without this, examples:
connect(new QShortcut(QKeySequence("Ctrl++"), this), &QShortcut::activated, this, [=]() { zoomIn(); });
connect(diskUsage, &DiskUsage::enteringDirectory, [=]() { DiskUsageViewer::slotUpdateStatus(); });
Oct 21 2018
Oct 19 2018
In D16223#345641, @nmel wrote:In D16223#344556, @mchabrecek wrote:I can push it, I might need some help:
Is it enough to merge my branch to master, add code review link (= Differential revision https://phabricator.kde.org/D16223 ??) and push the master?
Or is there something more?Since this is a single change and not multiple related changes, I would squash your branch into a single commit, rebase on top of the master, add the CR link and push it. Thanks!
Oct 17 2018
In D16223#344206, @nmel wrote:In D16223#344018, @mchabrecek wrote:Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?
For minor tweaks like this we usually approve and let author incorporate the fixes before pushing. Just to reduce turnaround time. Of course, if someone else pushes (or lands) the change, the author should send updated diff first.
Miroslav, are you going to push this change to the repo or you want us to do it? I think it's worth getting the permission as you're going to do several consecutive changes on this refactoring and, hopefully, other improvements. Please read our commit guidelines before pushing.
Oct 16 2018
- Fixed spacing
In D16223#343997, @nmel wrote:Thanks and welcome aboard Miroslav!
Oct 15 2018
I have submitted the first patch here regarding signals and slots. It doesn't solve all the connect() statements. There many hundreds of them. I want to do it in more patches. One reason is that this is my first patch to this project. So I didn't work at something for 6 months and then struggle to submit it. It is here, can you check it? https://phabricator.kde.org/D16223.
Oct 9 2018
Thank you for help,
Oct 6 2018
Hello,
I started to work on replacing old connect() wih Qt5 syntax.
Alex wrote me that it would be the best to do automatically by some script, I don't see it realistic.
There are some tricky cases, which I don't know how to convert. May be you can help me.