I don't have commit access, can you please land it for me? Thanks.

This is a follow-up to https://phabricator.kde.org/D13379

Use member variable

In D13379#274701, @mlaurent wrote:

Works fine
Thanks.

Do you have commit access or do you want that I commit it ?

The keepassx pull request:

No, I haven't.

Thank you, that caused the issue.

In D12373#253569, @davidedmundson wrote:

mimeData is key value pairs, you can have many pieces of mimeData.

So we have text/plain with the password as before
and x-kde-passwordManagerHint data "secret"

We still use the text/plain mimeData for context, but klipper ignores entries where that other mimeData is present.

Some facts:

• The clipboard in KDE is a QClipboard instance.
• Klipper is a frontend to the clipboard with a history. It exchanges data with the QClipboard instance.
• QClipboard provides the facility of setting mime types with data it stores. All data it stores (QMimeData) has a mime type associated.
• There is no such thing like a hint in QClipboard. There is only the mime type every data is associated with.
• Keepassx (and others) store their passwords and other data with mime type 'text/plain' in the clipboard.

Klipper: Fix option RemoveTopHistoryItemOnClear

You are right, the "prevent empty clipboard" option needs to be set to false to make the "RemoveTopHistoryItemOnClear" option work correctly.

In D12373#250306, @davidedmundson wrote:

Right, but pressing control+v again won't paste the item after clearing which I assumed was the intended goal

In D12373#250303, @davidedmundson wrote:

Aren't you just duplicating the existing "prevent empty clipboard" option ?

• Make settings const, request by elvisangelaccio

I changed the title of this revision. Is this sufficient or is a new commit needed?

Thanks, too. This is my first patch to a KDE project, so I don't have a developer account. Could you please land it for me? Thanks.

Implemented changes requested by Emmanuel Pescosta:

• clear selection when visiting base url

Implemented changes requested by Emmanuel Pescosta:

• renamed option to 'Limit to Home Directory'
• show option only if inside home

Implemented changes requested by Emmanuel Pescosta:

• using QString::SkipEmptyParts
• removed unnecessary change
• rephrased condition for readability
• renamed refreshFoldersPanel(), converted to private method reloadTree()

• Implemented changes reqeuested by Elvis Angelaccio:
• fixed patch

• Implemented changes requested by Elvis Angelaccio:
  • moved checkbox from main settings dialog to context menu of folders panel
  • added missing braces (coding style)
  • changed default to enabled
  • fixed regression: folders not expanding, caused by wrong directory string splitting