Coding style: missing braces

Use dolphin_folderspanelsettings.kcfg instead.

Also, the default should probably be true (see https://bugs.kde.org/show_bug.cgi?id=191917).

I don't think we should add a checkbox in the main settings dialog, we could just add it in the context menu of the panel (treeviewcontextmenu.cpp).

At this point, a previous selection needs to be cleared, only if homeUrl == url. The previous selection won't correspond to the currently active home directory.

If homeUrl is a parent of url and not equal, the selection is correctly changed.

I changed this, because the selection wasn't updated correctly. But if I change it back, I cannot reproduce this behaviour now. The change in kfileitemmodel.cpp has fixed this, too, so I removed the change here.

This shouldn't be required, see FoldersPanel::slotLoadingCompleted.

This change is from our original patch against KDE4 I ported. Neither do I know why this was changed, nor does it seem to have any negative effects to leave it out. So I removed the change.

Here, it is required: if a subdirectory of home has been selected previously before selecting home itself, the previous selection is not cleared. There is nothing to be newly selected in the folders panel in this case.

FoldersPanel::slotLoadingCompleted already clears the selection and thus this special case shouldn't be required.

Your patch, without this changes, works fine locally (e.g. when going from / to ~).
Can you please provide the exact steps to make it fail? Thanks!

More consistent would be something like "Limit to Home Directory if Inside Home", because we use capital letters for action labels.

But I would prefer a shorter action label like "Limit to Home Directory" but with an additional tool tip to describe the exact behavior.

@elvisangelaccio, @hoffmannrobert: What do you think?

1. Create a subdirectory of ~ , e.g. ~/Documents
2. go there --> Documents is selected in folders panel,
3. go back to ~ --> fail, selection in folders panel stays at Documents and is not cleared.

4. Create another subdirectory level. e.g. ~/Documents/Test
5. go there --> Documents/Test is selected in folders panel,
6. go back to ~ --> fail, selection in folders panel stays at Documents/Test and is not cleared.

Tooltips are disabled by default, so if somebody looks at Trash or Network, for example, and opens the folders panel context menu, the 'Limit to Home Directory' without further explanation would not make sense.

In these cases, the option should be invisible or deactivated, I suggest.

Now, the option is only shown if the selected url is inside home. I think, this is expected behaviour in a context menu.

Thanks for the steps! I can now reproduce the problem.

Please note that the same behavior occurs when e.g. going back from /home to /.

The reason is that the index is -1 (preventing the immediate updateCurrentItem in line 347) but the url is already loaded and so slotLoadingCompleted won't be called.

I would suggest something like this to fix the problem:

if (index >= 0) {
    updateCurrentItem(index);
} else if (url == baseUrl) {
    // clear the selection when visiting the base url
    updateCurrentItem(-1);
} else {
    ...
}