Changing this to invalid since we've postponed MIDI file playing features to future versions. Please refile it in bugs.kde.org if it happens again.

This is working fine for exercises. I'm changing this to invalid since we've postponed MIDI file playing features to future versions. Please refile this in bugs.kde.org if it happens again.

Maybe changing the playing label from "00:00:00" to "00:00:00 of 00:00:00" or "00:00:00" to "00:00:00 / 00:00:00" would be an option? We should try don't cluttering UI too much.

Changing to invalid since we've postponed MIDI file playing features to future versions. Showing the file name in mainwindow bar seems to be the best approach.

Changing do invalid. It seems it's been fixed already. Please file this in bugs.kde.org if you start experiencing it again.

Fixed in 9d6a7821581bb74be49d7fb3077b71de33bf1cb7

Abandoning it, since we've postponed MIDI file playing features to future versions.

Abandoning it by now, since we've postponed MIDI file playing features to future versions. Thanks for submiting the patch.

I'm abandoning that by now, since we postponed MIDI files playing features to v0.2 or v0.3.
Thanks for sending the patch.

Yeah space from the menu can be taken. Ultimately it would depend upon your implementation. If it looks great and tidy then there wont be any need to edit title.

Thanks for your feedback. Yes that would be a good idea but generally the file name is shown in the media bar There is some white space above the bar. So if we could increase the height of midi bar and then include the current song being played and occupy some space. If not possible then we could edit the title :)

The only problem is label's position and space. I have implemented progress bar for the the player which took some of the available space. It will get merged in some time.
How about editing the application title instead of adding a label?

This problem can be solved by removing the files(minuet folder) from installed directory(generally /usr/share/) and then re installing.

I am using Fedora 23

Yeah, did another git pull. no change.
What is you OS configurations?

Happened with me too. Try reinstalling.
This is happening because the file "major-scale-and-its-modes.json" has been changed to "scales-major-and-its-modes.json".
Maybe it should be renamed back to what it was.
Duplicate files are copied in exercises folder of Minuet and then they get loaded by exercise controller.

Are you sure you have the updated repository, because those two exceptions used to occur before

Thanks for testing. Looks like its specific to my installation. No matter what I do I always have this crash.
Setting midi file path manually does not get me a segfault upon closing Minuet.

Hey, I guess it has already been resolved. I followed these steps

1. Open file window.
2. Click on close dialog button
3. Click on Minuet close dialog button.

Here is the update,
For the first case, its not the fault of playing midi file. Simply opening the file open window and then closing Minuet leads to a crash.

@itsback Thank you for your help. I really appreciate it.

@ahassan Dont drop diff here, create a differential at https://phabricator.kde.org/differential/diff/create/
It will make testing and reviewing easy.

Should the states in State enum be in all caps?
like STOPPED_STATE instead of StoppedState?

This update should remove the interference between the two play buttons in exercise and MIDI player controls. And it will work on the latest one. Like if our exercise was working and now we open a .mid file, now only the MIDI player controls will work, and pressing the play exercise button won't have any effect. Similarly, if the midi file is playing and we request for a new exercise, the midi player will be turned off (timer to 0) and the exercise will play. Now the MIDI player play button won't work. Before creating a new exercise, I have stopped the midi player first and then cleared the old Song object for midi before creating a new song object.

Drumstick's GUI player has a progress bar. So I went through its code and found that SMFNoteOn signal is sent when a file is being read by drumstick::QSmf *m_smfReader. The smf reads whole file and from this me can get maximum current time.
When song will be played we can get the percentage and set value of progressbar, as Drumstick does.

But the output thread is stopped by m_midiSequencer->stop(); as it calls m_midiSequencerOutputThread->stop();
And m_midiSequencerOutputThread->stop() is defined in Drumstick so we can assume that they are safely closing the thread.

This is actually wrong, because you should interrupt the output thread first and wait for its termination. Otherwise, you get occasional crashes.

Please make the suggested change and ship it!

Ship it!

Please make the suggested changes and submit a new patch in this same Differential D1106.
Also, please rebase your changes against current master state, since new commits have arrived since then.

We already have a differential for this.
https://phabricator.kde.org/D1112

I am able to fix the second case by adding

m_midiSequencerOutputThread->stop();

to MidiSequencer's destructor.

The button now changes back to 'Play' state after playback is finished.

Available at https://minuet.kde.org