Correcting pitch change
AbandonedPublic
Actions

Authored by itsback on Mar 10 2016, 9:02 PM.

Details

Reviewers

Summary

When slider is moved below 0, a negative pitch shift is sent to

MidiSequencer::setPitchShift(unsigned int value)

which takes it as an unsigned int due to which "unsigned int max" value is shown in MidiPlayer in Minuet.
Changing all the unsigned int pitch values to signed int solves the issue.

Diff Detail

Repository

R163 Minuet

Lint

Lint Skipped

Unit

Unit Tests Skipped

itsback updated this revision to Diff 2680.Mar 10 2016, 9:02 PM

itsback retitled this revision from to Correcting pitch change.

itsback updated this object.

itsback edited the test plan for this revision. (Show Details)

itsback added a reviewer: sandroandrade.

itsback set the repository for this revision to R163 Minuet.

itsback added a subscriber: itsback.

Ship it!

Please ensure that the first line of your commit log starts with a verb in infinitive form (ex: Fix pitch change)
Also, ensure that your commit log has the following line (after the first line):

Differential Revision: D1112

so that this review is automatically closed by Phabricator.

This revision is now accepted and ready to land.Mar 15 2016, 2:03 AM

sandroandrade commandeered this revision.Mar 15 2016, 2:07 AM

sandroandrade edited reviewers, added: itsback; removed: sandroandrade.

This revision now requires review to proceed.Mar 15 2016, 2:07 AM

sandroandrade removed a reviewer: itsback.Mar 15 2016, 2:54 AM

sandroandrade added a reviewer: itsback.

sandroandrade removed a subscriber: itsback.

itsback resigned from this revision.Mar 16 2016, 10:27 PM

itsback removed a reviewer: itsback.

sandroandrade added a reviewer: itsback.Mar 18 2016, 12:15 AM