Fix for T1848: Interference of 'Play Question' with the play button of MIDI player controls
AbandonedPublic

Authored by sandroandrade on Mar 19 2016, 6:51 AM.

Details

Reviewers
ahassan
Summary

This update should remove the interference between the two play buttons in exercise and MIDI player controls. And it will work on the latest one. Like if our exercise was working and now we open a .mid file, now only the MIDI player controls will work, and pressing the play exercise button won't have any effect. Similarly, if the midi file is playing and we request for a new exercise, the midi player will be turned off (timer to 0) and the exercise will play. Now the MIDI player play button won't work. Before creating a new exercise, I have stopped the midi player first and then cleared the old Song object for midi before creating a new song object.

Test Plan

Open any exercise, you should only be able to play it using the play question button, and the play button in MIDI player control shouldn't do anything.
Open a .mid file and play it (it is the current Song object now). Now try to use the play button from exercise panel (that was already open), which shouldn't have any effect on the .mid playing.
Now open another exercise (it is the current song); it should stop the .mid playing, return the timer to 0, and play exercise music.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
ahassan updated this revision to Diff 2842.Mar 19 2016, 6:51 AM
ahassan retitled this revision from to Fix for T1848: Interference of 'Play Question' with the play button of MIDI player controls.
ahassan updated this object.
ahassan edited the test plan for this revision. (Show Details)
ahassan added a reviewer: sandroandrade.
ahassan set the repository for this revision to R163 Minuet.
ahassan added a project: Minuet.
ahassan added a subscriber: ahassan.
sandroandrade commandeered this revision.May 26 2016, 6:50 PM
sandroandrade abandoned this revision.
sandroandrade edited reviewers, added: ahassan; removed: sandroandrade.

Abandoning it by now, since we've postponed MIDI file playing features to future versions. Thanks for submiting the patch.