Differential D1018

T1674 Review code - Fix bug that helps in resuming of exercise instead of restarting it after pause is clicked
ClosedPublic
Actions

Authored by ayushshah on Feb 24 2016, 1:07 PM.

Details

Reviewers
sandroandrade

Diff Detail

Repository
R163 Minuet
Lint
Lint Skipped
Unit
Unit Tests Skipped
ayushshah updated this revision to Diff 2452.Feb 24 2016, 1:07 PM
ayushshah retitled this revision from to T1674 Review code - Fix bug that helps in resuming of exercise instead of restarting it after pause is clicked.
ayushshah updated this object.
ayushshah edited the test plan for this revision. (Show Details)
ayushshah added a reviewer: sandroandrade.
ayushshah set the repository for this revision to R163 Minuet.
ayushshah added a project: Minuet.
ayushshah added a subscriber: ayushshah.
sandroandrade accepted this revision.Mar 3 2016, 12:21 AM
sandroandrade edited edge metadata.

Please make the slight change required and ship it.

src/midisequencer.cpp
182

You don't actually need to check this but it's useful to have it here since when playing MIDI files setSong is called when opening the file. Removing that would make setSong be invoked every time the playing is started and that isn't needed at all.

183

Change it to:

if(m_midiSequencerOutputThread->getInitialPosition() == 0 || !m_midiSequencerOutputThread->hasNext()))

for sake of clarity.

Change that and SHIP IT.

This revision is now accepted and ready to land.Mar 3 2016, 12:21 AM
ayushshah closed this revision.May 26 2016, 6:10 PM

Revision Contents
Changeset List

PathPackages
Msrc/midisequencer.cpp (6 lines)

Diff 2452

View Options

src/midisequencer.cpp

Loading...