Not all item types allow 'extra value' to be specified for the data source. Are you happy allowing the property for all item types?

It works for me! So one potential fix remains.

Good job!
First comments, have not tested yet.

Does it work for you in master?

Some more qustions @piggz ...

• addres comments

Good, minor ones left.

Good job!

• Re-order and andd envelope sizes

Related note: if you open LO Writer's page format dialog, there is no custom size property but just size:

Apparently resolved within T6559.

I cant reproduce this, is it fixed for you?

Maybe 5.x can be improved later.

You are happy with 5.x?

Please test relevant features after my last commit, I think we can then land this :)

• Merge branch 'master' into D5441
• Make KReportUtils::readSizeAttributes() return default size also for invalid width or height; simplify readRectAttributes()
• Use QRectF for bounding boxes/font metrics as long as we're using floating-point positions and sizes
• Avoid double call of KReportDesignerItemRectBase::setSceneRect() what can lead to setting invalid size
• Fix performance of sections resize, unit conversion, and allow to resize sections using property editor

@piggz I'd like to ask for review of D8518 ASAP so we have it in master otherwise number of conflicts increase! :)

In D5441#161577, @piggz wrote:

could you confirm if 5.3.1 -> 5.3.4 are possible?

• Merge with kproperty API change 3.0.91

could you confirm if 5.3.1 -> 5.3.4 are possible?

• Calculate sensible maximums for margin sizes

In D5441#160064, @piggz wrote:

In D5441#157528, @staniek wrote:

6. If 0.00 value is entered it disappears in the prop. editor when moving focus to another editor. Data is saved though. Expected: 0.00 is visible. Example for margins:
   
   
   
   
   
   This may or not be related to the KProperty libs and as such can belong to me :)

it belongs to you ;)

Merge in master changes.

@piggz Ready for review I think. Most of the code here is moved around so we can call clearModifiedFlags() unconditionally when we're done with initializing, no matter if we create new elements or load them from XML.

• Add clearModifiedFlags() for more property sets on initialization (usually loading from XML)

This is initial patch. Trying to add more fixes like this.

In D5441#160067, @piggz wrote:

What do you think is a sensible max for margins? a % of the width/height? or some complex calculation involving calculating the size of the page and opposite margin?

What do you think is a sensible max for margins? a % of the width/height? or some complex calculation involving calculating the size of the page and opposite margin?

In D5441#157528, @staniek wrote:

6. If 0.00 value is entered it disappears in the prop. editor when moving focus to another editor. Data is saved though. Expected: 0.00 is visible. Example for margins:
   
   
   
   
   
   This may or not be related to the KProperty libs and as such can belong to me :)

Fixed in units makes 4.2 fixed!

@piggz 7.x all fixed!

4.1, 5.1 fixed, good work. Added 5.2 and 5.3.

In D5441#157528, @staniek wrote:

6. If 0.00 value is entered it disappears in the prop. editor when moving focus to another editor. Data is saved though. Expected: 0.00 is visible. Example for margins:
   
   
   
   
   
   This may or not be related to the KProperty libs and as such can belong to me :)

Note, I cannot reproduce 7.3. Scrolling mouse over grididivsions works as expected.

• Set min/max values for grid divisions

• 7.1. Grid Divisions property allows to enter <=0 valued. Expected: minimum value should be 1. (use property option for that)

• 6. If 0.00 value is entered it disappears in the prop. editor when moving focus to another editor. Data is saved though. Expected: 0.00 is visible. Example for margins:

• Fix dynamic redraw of background. Resolved issue 4.1 and 5.1

these issues explain the call to slotResizeBarDragged(0) ... need to find a fix wthout introducing it ... calling update() doesnt cause a resize to happen

Dupe

Sync with master

All OK @piggz! Works so well now.

Merge with master

• Fix section changing height when untis changed

• Fix custom page size handling when changing units

Fixes 2.2

In D5441#148425, @piggz wrote:

• Fix items dissapearing

In D5441#148682, @piggz wrote:

fixed 2.1 and 2.3

fixed 2.1 and 2.3

• Fix items dissapearing

Thanks Adam, that's gigantic step forward, we're almost there.

1st step done: reviewed the rebase https://phabricator.kde.org/D5441?vs=13438&id=19211. Good job!

• Convert margins correctly when calculating page width

• Fix crash when changing unit of a line

• When changing section unit, set the unit before setting the height to

• Fixup margins to get basic rendering working again

rebased

Cool :)

• Minor fixes

Minor questions

• Move sections to d ptr