Create Task
Maniphest T6773

3.1: Add missing d-pointers to KReport
Closed, ResolvedPublic
Actions

Description

Remaining fixes.

Add d-pointers:

  • KReportAsyncItemBase

d-pointers present but move m_* variables:

  • KReportDocument
  • KReportDesignerItemRectBase

Details

Differential Revisions
D7638: Move remaining memebers of KReportDesignerItemRectBase to dptr

Related Objects

staniek created this task.Aug 12 2017, 12:57 PM
piggz added a comment.Aug 30 2017, 7:29 PM

I thought for KReportASyncItemBase, we agreed because it was trivial, a dptr wasnt required. Thoughts?

staniek added a comment.Aug 30 2017, 7:36 PM

Yes but it's not value-based and if it ever needs a member we're in trouble as d-pointer a cannot be added in 3.x.

piggz added a comment.Aug 31 2017, 8:39 PM

Ok, and for KReportDocument, move the protected m_ variables to d, and add protected getters/setters?

piggz updated the task description. (Show Details)Aug 31 2017, 9:05 PM
piggz closed this task as Resolved.Sep 4 2017, 8:20 PM
piggz updated the task description. (Show Details)