Notify document when async item is rendered

Authored by piggz on Jan 16 2018, 10:23 PM.



async items like web and map do not notify the document when an item is rendered

Test Plan

Open report with web view and see renders appear as they become available

Diff Detail

R14 KReport
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
piggz created this revision.Jan 16 2018, 10:23 PM
Restricted Application added a project: KReport. · View Herald TranscriptJan 16 2018, 10:23 PM
piggz requested review of this revision.Jan 16 2018, 10:23 PM
staniek requested changes to this revision.Jan 16 2018, 10:36 PM

Good job!
First comments, have not tested yet.


Not needed since m_curPage->document() can be used.


I hope it's safe to keep this raw pointer (wrt OROPage lifetime)?

This revision now requires changes to proceed.Jan 16 2018, 10:36 PM

It works for me! So one potential fix remains.

This revision was not accepted when it landed; it landed in state Needs Revision.Jan 19 2018, 10:19 PM
This revision was automatically updated to reflect the committed changes.
piggz marked 2 inline comments as done.Jan 19 2018, 10:30 PM

Note to ourselves: forgot to include it in 3.1 beta so it goes to the next minor version.