Add additional page sizes

Authored by piggz on Oct 30 2017, 6:54 PM.



Add page sizes as per calligra

Test Plan

Select page sizes in property editor

Diff Detail

R14 KReport
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
piggz created this revision.Oct 30 2017, 6:54 PM
Restricted Application added a project: KReport. · View Herald TranscriptOct 30 2017, 6:54 PM
staniek added inline comments.Oct 30 2017, 8:34 PM

Planned to mention this before: screen is not something intuitive, how about removing it?

That's true, unlike LO Writer, LO Impress has Screen 4:3 and other sizes because Screen is the target medium for presentations.

For us it can be too but it's not clear what orientation and what screen do we mean. Power users have custom size to easily apply screen geometry if really needed.





Calligra has no envelope types, Qt has, and our users may need it. How about appending:

(grabbed from LO, it must be that they picked most popular on all OSes)

staniek requested changes to this revision.Oct 30 2017, 8:34 PM
This revision now requires changes to proceed.Oct 30 2017, 8:34 PM
piggz updated this revision to Diff 21593.Oct 30 2017, 10:24 PM
  • Re-order and andd envelope sizes
piggz marked 3 inline comments as done.Oct 30 2017, 10:25 PM
staniek accepted this revision.Oct 30 2017, 10:36 PM

Good job!

This revision is now accepted and ready to land.Oct 30 2017, 10:36 PM
This revision was automatically updated to reflect the committed changes.