- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Mar 28 2023
Unsure. Not moving to https://invent.kde.org/libraries/kreport/-/issues
Obsolete
Not moving to Gitlab as Postgresql may be less maintained
Still a TODO? Not moving to Gitlab
README is there already
Extended to cmake as well
https://invent.kde.org/libraries/kproperty/-/issues/1
https://invent.kde.org/libraries/kreport/-/issues/1
Mar 15 2023
Fixed already probably
Done in the Invent
May 30 2020
Respective merge requests are created now here:
https://invent.kde.org/libraries/kdb/-/merge_requests/1
https://invent.kde.org/libraries/kproperty/-/merge_requests/1
https://invent.kde.org/libraries/kreport/-/merge_requests/1
May 29 2020
Great, thanks Friedrich.
@staniek Ah, missed your reply, somehow phabricator did not send me a noticiation.
May 27 2020
Hi Freidrich. That's a good news to me!
Hi @staniek . While I am currently doing some work to keep api.kde.org alive and cleaning up legacy docs where possible, I remembered this task and would be available to complete it these days :)
May 10 2020
Fixed style issue
May 9 2020
May 3 2020
Change error message to be easier to translate and to understand, taking care that quoting characters are not quoted
May 2 2020
Fix summary
Remove the unrelated change for indentifier escaping
Add comment to fallback rules that now report an actual error
May 1 2020
Beware that the SQL query in the summary will not work without the change in D29277 and it will fail with
Apr 29 2020
In D29277#659789, @staniek wrote:Related fix in KEXI 3.2 would be welcome.
Entering "select id from [table]" in KEXI SQL editor or passing it to a parser in C++ raises the same parser's error.
In order to reproduce bug you're fixing above one needs to create a queryfully using the C++ API since the parser won't let the to go reserved identifiers through.
(until the #332161 is solved)
In D29277#659787, @staniek wrote:Thanks. Is there any relation to https://bugs.kde.org/show_bug.cgi?id=420599?
Another note so we won't forget. Update for autotests (both positive and negative). Here's the branch https://bugs.kde.org/show_bug.cgi?id=332161#c8
To be sure, you're constructing a query using C++ classes and not using the parser?
I am asking because to me "select id from [table]" does not work since we do not (yet) support identifier escaping with [].
Related fix in KEXI 3.2 would be welcome.
Thanks. Is there any relation to https://bugs.kde.org/show_bug.cgi?id=420599?
Fix indent
Apr 25 2020
Good job!
Thanks. Looks good. For the future, bugfixes can go to the 3.2 branch - it will be easier to apply. Otherwise I need to cherry-pick a commit.
Thank you Jordi, I will review it. This looks like a wonderful example app!
Apr 24 2020
My plan is to include the example as a tutorial in the documentation, but first i wanted for you to review the code alone and see all i did wrong.
Jan 15 2019
@piggz
Pushed for 3.2 Beta, post-commit review would be welcome.
Jan 14 2019
Jan 4 2019
Update to 3.2
Jan 1 2019
- Update API docs for KDbDriverManager::driverIdsForMimeType()
In D17887#384770, @pino wrote:I don't understand what is tested in KDbTestUtils::testDriver() now, related to the mimetypes. The old logic looked better (and simpler too) to me, I'd just leave that.
The only simple addition IMHO is that manager.driverIdsForMimeType(mimeName) returns a valid driver for each of the mimetypes specified in the plugin metadata.
I don't understand what is tested in KDbTestUtils::testDriver() now, related to the mimetypes. The old logic looked better (and simpler too) to me, I'd just leave that.
The only simple addition IMHO is that manager.driverIdsForMimeType(mimeName) returns a valid driver for each of the mimetypes specified in the plugin metadata.
Tested before and after adding application/vnd.sqlite3 to the system (exact FD.o patch) - it works only thanks to keeping the old x-sqlite3 type in the JSON and because FD.o has an alias. Good that I asked about json, otherwise it would fail for me. Added more extensive tests to verify. Thanks @pino and be welcome to more reviews :)
- Resolve plugin mime types before adding metadata - idea from from Pino
- Add autotests for checking detection of every mime type that should be supported
In D17887#384699, @staniek wrote:In D17887#384687, @pino wrote:In D17887#384686, @staniek wrote:Shorter: what change in kdb_sqlitedriver.json do you propose?
With the draft of patch I proposed, none.
OK but that means you propose to revert change for the json or keeping the change as is?
In D17887#384687, @pino wrote:In D17887#384686, @staniek wrote:Shorter: what change in kdb_sqlitedriver.json do you propose?
With the draft of patch I proposed, none.