jfita (jordi fita i mas)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 8 2020, 10:46 PM (210 w, 1 d)
Availability
Available

Recent Activity

May 16 2020

jfita added a comment to D29804: Fix KI18n’s (I18N_ARGUMENT_MISSING) warnings in migration.

This is related to https://forum.kde.org/viewtopic.php?f=221&t=165454.

May 16 2020, 11:50 PM · KEXI
jfita requested review of D29804: Fix KI18n’s (I18N_ARGUMENT_MISSING) warnings in migration.
May 16 2020, 11:49 PM · KEXI
jfita added inline comments to D29230: Improve KexiRecordNavigator’s scroll wheel sensitivity.
May 16 2020, 8:05 PM · KEXI
jfita added a comment to D28809: Expand the documentation’s main page with an overview and example.

Amazing to have someone using my work, can I ask what app you are using it in?

May 16 2020, 7:48 PM · KReport
jfita updated the diff for D28828: Remove automoc warnings when building plugins.

Updated required version of ECM to use ECMSetupQtPluginMacroNames. It is now
based on master (3.3) instead of the 3.2 branch

May 16 2020, 7:30 PM · KReport

May 10 2020

jfita added inline comments to D29327: Improve a bit parse error diagnosis.
May 10 2020, 9:06 PM · KDb
jfita updated the diff for D29327: Improve a bit parse error diagnosis.

Fixed style issue

May 10 2020, 9:03 PM · KDb

May 3 2020

jfita added inline comments to D29327: Improve a bit parse error diagnosis.
May 3 2020, 8:38 PM · KDb
jfita updated the diff for D29327: Improve a bit parse error diagnosis.

Change error message to be easier to translate and to understand, taking care that quoting characters are not quoted

May 3 2020, 8:31 PM · KDb

May 2 2020

jfita added inline comments to D29327: Improve a bit parse error diagnosis.
May 2 2020, 1:48 PM · KDb
jfita updated the diff for D29327: Improve a bit parse error diagnosis.

Fix summary

May 2 2020, 12:18 AM · KDb
jfita updated the diff for D29327: Improve a bit parse error diagnosis.

Remove the unrelated change for indentifier escaping

May 2 2020, 12:13 AM · KDb
jfita added inline comments to D29327: Improve a bit parse error diagnosis.
May 2 2020, 12:12 AM · KDb
jfita updated the diff for D29327: Improve a bit parse error diagnosis.

Add comment to fallback rules that now report an actual error

May 2 2020, 12:03 AM · KDb

May 1 2020

jfita added a comment to D29346: Quote and parse identifiers with square brackets.

Beware that the SQL query in the summary will not work without the change in D29277 and it will fail with

May 1 2020, 7:26 PM · KDb
jfita requested review of D29346: Quote and parse identifiers with square brackets.
May 1 2020, 7:20 PM · KDb
jfita requested review of D29327: Improve a bit parse error diagnosis.
May 1 2020, 1:08 PM · KDb

Apr 29 2020

jfita added a comment to D29277: Escape table name in when building a select statement with row id.

Related fix in KEXI 3.2 would be welcome.

Apr 29 2020, 6:50 PM · KDb
jfita requested review of D29286: Show error when can not switch to data view for tables.
Apr 29 2020, 6:42 PM · KEXI
jfita added a comment to D29277: Escape table name in when building a select statement with row id.

Thanks. Is there any relation to https://bugs.kde.org/show_bug.cgi?id=420599?

Apr 29 2020, 3:33 PM · KDb
jfita updated the diff for D29277: Escape table name in when building a select statement with row id.

Fix indent

Apr 29 2020, 2:24 PM · KDb
jfita requested review of D29277: Escape table name in when building a select statement with row id.
Apr 29 2020, 2:21 PM · KDb

Apr 27 2020

jfita requested review of D29244: Show property editor in text view mode too.
Apr 27 2020, 11:18 PM · KEXI
jfita requested review of D29243: Select design or text view mode for new items.
Apr 27 2020, 10:55 PM · KEXI
jfita added a comment to D29230: Improve KexiRecordNavigator’s scroll wheel sensitivity.

Here are a couple of GIF showing the issue before and after the changes in this commit.

Apr 27 2020, 1:25 PM · KEXI
jfita requested review of D29230: Improve KexiRecordNavigator’s scroll wheel sensitivity.
Apr 27 2020, 1:20 PM · KEXI

Apr 25 2020

jfita requested review of D29186: Fix SqliteCursor’s buffering.
Apr 25 2020, 8:12 PM · KDb
jfita requested review of D29185: Expand feature test for buffered cursors.
Apr 25 2020, 7:39 PM · KDb
jfita requested review of D29184: Take all args to kdbfeaturestest before the driver.
Apr 25 2020, 7:30 PM · KDb
jfita added reviewers for D28828: Remove automoc warnings when building plugins: staniek, piggz.
Apr 25 2020, 2:38 AM · KReport

Apr 24 2020

jfita added a comment to D29166: Add cached table example.

My plan is to include the example as a tutorial in the documentation, but first i wanted for you to review the code alone and see all i did wrong.

Apr 24 2020, 10:12 PM · KDb
jfita requested review of D29166: Add cached table example.
Apr 24 2020, 10:09 PM · KDb

Apr 20 2020

jfita added a comment to D28809: Expand the documentation’s main page with an overview and example.

BTW, while creating reviews please add at least me and KReport maintainer Adam as reviewers. Thanks!

Apr 20 2020, 12:59 PM · KReport
jfita updated the diff for D28809: Expand the documentation’s main page with an overview and example.

Improve wording, remove use of QLatinString/QStringLiteral, and make code follow conventions better

Apr 20 2020, 12:55 PM · KReport

Apr 18 2020

jfita updated the diff for D28809: Expand the documentation’s main page with an overview and example.

Fix wording, and remove improper use of auto and pointer validity according to coding style

Apr 18 2020, 9:31 PM · KReport

Apr 16 2020

jfita updated the diff for D28809: Expand the documentation’s main page with an overview and example.

Updated text according to Jarosław’s notes

Apr 16 2020, 9:53 PM · KReport

Apr 14 2020

jfita requested review of D28828: Remove automoc warnings when building plugins.
Apr 14 2020, 2:33 PM · KReport

Apr 13 2020

jfita requested review of D28809: Expand the documentation’s main page with an overview and example.
Apr 13 2020, 9:33 PM · KReport

Apr 11 2020

jfita requested review of D28763: Set the script source for KReportDesigner and KReportPreRenderer in the example.
Apr 11 2020, 8:20 PM · KReport
jfita requested review of D28762: Call updateScripts in KReportDesigner::setScriptSource.
Apr 11 2020, 8:13 PM · KReport
jfita added a comment to D28736: Add Qt5PrintSupport and KF5CoreAddons dependencies to CMake config.

If we want it in the stable 3.2 release, it needs to land in the 3.2 branch.

Apr 11 2020, 12:52 AM · KReport

Apr 10 2020

jfita requested review of D28736: Add Qt5PrintSupport and KF5CoreAddons dependencies to CMake config.
Apr 10 2020, 10:31 PM · KReport

Apr 8 2020

jfita requested review of D28694: Fix warning message for missing report:connection.
Apr 8 2020, 11:18 PM · KEXI