Take all args to kdbfeaturestest before the driver
ClosedPublic

Authored by jfita on Apr 25 2020, 7:30 PM.

Details

Summary

kdbfeaturetest gave the following error when trying to test buffered
cursors:

> .//kdbfeaturestest --buffered-cursors --test cursors sqlite /tmp/cursor.test
DRIVERS:  ("org.kde.kdb.postgresql", "org.kde.kdb.sqlite")
org.kde.kdb.core: loading "org.kde.kdb.--buffered-cursors"
KDbResult: CODE=10 MESSAGE="Could not find database driver \"org.kde.kdb.--buffered-cursors\"." SERVER_ERROR_CODE=0
main: "cursors" test: ERROR

kdbfeaturetest’s main tries to remove all arguments from args[] before
using the first remaining string as the driver’s name, but the code that
removes --buffered-cursors and --query-parameters was below the one for
the driver. Therefore, it assumed that either of the two, since they
where still in args, was the driver’s name.

I just moved the two calls to take those parameters above the driver.

FIXED-IN:3.2.1

Diff Detail

Repository
R15 KDb
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jfita created this revision.Apr 25 2020, 7:30 PM
Restricted Application added a project: KDb. · View Herald TranscriptApr 25 2020, 7:30 PM
Restricted Application added a subscriber: Kexi-Devel-list. · View Herald Transcript
jfita requested review of this revision.Apr 25 2020, 7:30 PM
staniek added a comment.EditedApr 25 2020, 8:52 PM

Thanks. Looks good. For the future, bugfixes can go to the 3.2 branch - it will be easier to apply. Otherwise I need to cherry-pick a commit.

New features can go to master.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2020, 8:56 PM
This revision was automatically updated to reflect the committed changes.
staniek reopened this revision.Apr 25 2020, 8:58 PM
staniek accepted this revision.
This revision is now accepted and ready to land.Apr 25 2020, 8:58 PM
staniek closed this revision.Apr 25 2020, 8:59 PM