Removed some assertions and dynamic_cast a pointer instead of a reference

Fixed the license header to display 2018 instead 2017
Add an assertion to check that the given iCal is valid in the Event property extractor

nvm. I'll land this and we can do the next step separately.

Given the comment on https://phabricator.kde.org/D12087, I'll wait for those changes until I apply this.

In D12085#244123, @rnicole wrote:

I'm confused, the properties are registered in applicationdomaintype.cpp (line 131-132)

I'm confused, the properties are registered in applicationdomaintype.cpp (line 131-132)

Please also register the property in applicationdomaintype.cpp. The rest looks good.

I think this was caused by the newly added webdavcommon library. It lacked a dependency on sink_common, but depended on the generated headers.

The mail that runs off the side is not a mac specific problem and is actually a text view problem.

Fixed using some platform specific code.

The account wizard is fixed and the back button as well. The COMODO test mail runs off the side, other html mails look ok.

QT_MAC_DISABLE_FOREGROUND_APPLICATION_TRANSFORM is apparently the workaround to achieve this, but that of course does not work at all.

• Switch to local CalDAV server for unit tests (currently has an auth fail when using Kube's container)
• Add missing TypeHelper implementation (fixes the threadindexer warning, thanks Christian!)
• Remove an unused variable due to removing the attachment field in the Event type

I have verified that the image works with OS X 10.11.6.

The extra cmake modules contain similar code to enable various sanitizers.

The buildsystem can be found here:
https://github.com/cmollekopf/craft-kube/tree/mac

The HighDPI issues have been fixed. We still have a bunch of icons that are too small (action buttons on mails, some of the icons in the sidebar), but in general it looks ok now.
The webview seems to sometimes not correctly resize to the width of the page.

I've successfully built kube on osx high sierra.

Fixed by not using QGuiApplication but still linking to QtGui. (Not sure why I wasn't doing that in the first place.)

http://indiegamecodingconfessions.blogspot.ch/2014/03/getting-qtc-app-in-mac-app-store.html

We now have a .clang-format config in both kube and sink. No enforced automatic formatting happening yet though.

The reason for the above crash was specific to the testsetup.
When restarting the test-setup quickly, the still running resource ended up trying to write to the index that was already deleted by the new initial setup (we always delete all data on startup).
Just deleting stuff from the client side should of course never be done in something that goes to production, so this is not a problem we want to deal with.

We move mails to the sent mail folder.

This is now implemented.
What doesn't work is reloading the databases in the client process.
For this the process would have to receive a notification that allows it to nuke all in-process lmdb environments, otherwise we end up crashing on the next access to disk.
To avoid this kube currently just requires the user to restart the process.

We now have local fulltext search based on xapian.

There is now a "Change Password" button in the settings that brings up the login view again.