Differential D12106

Change most of Event's properties to extracted properties
ClosedPublic
Actions

Authored by rnicole on Apr 11 2018, 10:15 AM.

Tags

Subscribers

None

Details

Reviewers

Maniphest Tasks

T8485: Change most of Event's properties to extracted properties

Commits

R9:cd81aed81428: Change most of Event's properties to extracted properties

Summary

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

rnicole requested review of this revision.Apr 11 2018, 10:15 AM

rnicole created this revision.

Fixed the license header to display 2018 instead 2017
Add an assertion to check that the given iCal is valid in the Event property extractor

cmollekopf requested changes to this revision.Apr 12 2018, 11:23 PM

cmollekopf added inline comments.

common/eventpreprocessor.cpp
30	Q_ASSERT(incidence) is enough.
33	dynamic_cast'ing a reference is probably a bad idea. dynamic cast a pointer and wrap the user of the pointer in an if branch. Asserting is fine, but in production code we want to minimize crashing.

This revision now requires changes to proceed.Apr 12 2018, 11:23 PM

Removed some assertions and dynamic_cast a pointer instead of a reference

cmollekopf accepted this revision.Apr 13 2018, 9:51 AM

This revision is now accepted and ready to land.Apr 13 2018, 9:51 AM

Closed by commit R9:cd81aed81428: Change most of Event's properties to extracted properties (authored by rnicole, committed by cmollekopf). · Explain WhyApr 13 2018, 9:52 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			common/CMakeLists.txt (2 lines)
M			common/domain/applicationdomaintype.h (10 lines)
A	M		common/eventpreprocessor.h (35 lines)
A	M		common/eventpreprocessor.cpp (60 lines)
M			examples/caldavresource/caldavresource.cpp (8 lines)
M			examples/dummyresource/resourcefactory.cpp (7 lines)
M			tests/clientapitest.cpp (6 lines)

Diff 32045

CMakeLists.txt

Loading...

common/CMakeLists.txt

Loading...

common/domain/applicationdomaintype.h

Loading...

common/eventpreprocessor.h

Loading...

common/eventpreprocessor.cpp

Loading...

examples/caldavresource/caldavresource.cpp

Loading...

examples/dummyresource/resourcefactory.cpp

Loading...

tests/clientapitest.cpp

Loading...