Differential D12085

Add EndTime and Ical attributes to Event
ClosedPublic
Actions

Authored by rnicole on Apr 10 2018, 1:40 PM.

Details

Reviewers
cmollekopf
Maniphest Tasks
T8482: Add EndTime attribute to Event
Commits
R9:edbb4c9c82e3: Add EndTime and Ical attributes to Event
Summary

EndTime is necessary for the implementation of the calendar UI in Kube.
Fixes T8482

Ical to mimic Mail's MimeMessage attribute.

(Sorry for the wait, there was a good number of merge conflicts when rebasing on develop)

Diff Detail

Repository
R9 Sink
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rnicole requested review of this revision.Apr 10 2018, 1:40 PM
rnicole created this revision.
cmollekopf requested changes to this revision.Apr 11 2018, 8:21 AM

Please also register the property in applicationdomaintype.cpp. The rest looks good.

This revision now requires changes to proceed.Apr 11 2018, 8:21 AM
rnicole added a comment.Apr 11 2018, 8:34 AM

I'm confused, the properties are registered in applicationdomaintype.cpp (line 131-132)

cmollekopf added a comment.Apr 11 2018, 8:35 AM
In D12085#244123, @rnicole wrote:

I'm confused, the properties are registered in applicationdomaintype.cpp (line 131-132)

My bad, overlooked it ;-)

cmollekopf accepted this revision.Apr 11 2018, 8:36 AM

Given the comment on https://phabricator.kde.org/D12087, I'll wait for those changes until I apply this.

This revision is now accepted and ready to land.Apr 11 2018, 8:36 AM
cmollekopf added a comment.Apr 11 2018, 8:37 AM

nvm. I'll land this and we can do the next step separately.

Closed by commit R9:edbb4c9c82e3: Add EndTime and Ical attributes to Event (authored by rnicole, committed by cmollekopf). · Explain WhyApr 11 2018, 8:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31857

View Options

common/domain/applicationdomaintype.h

Loading...
View Options

common/domain/applicationdomaintype.cpp

Loading...
View Options

common/domain/event.fbs

Loading...
View Options

common/domain/typeimplementations.cpp

Loading...
View Options

examples/caldavresource/caldavresource.cpp

Loading...