Differential D11741

Add CalDAV support
ClosedPublic
Actions

Authored by rnicole on Mar 27 2018, 9:56 AM.

Details

Reviewers

cmollekopf

Maniphest Tasks

T8224: Implement CalDAV resource type

Commits

R9:761328989492: Add CalDAV support

Summary

Notes:

Add a webdavcommon folder for WebDAV generic resource code
Move davresource to carddaveresource and make it use the WebDAV code
For now it tests the CalDAV resource directly on KolabNow (to be changed)
Only synchronization, not adding / changing / removing WebDAV collections or items (to be implemented)
Only events are currently supported (todo, freebusy, etc. are to be implemented but should be straightforward)
~~Weird warning from the threadindexer saying it Found an email without messageId when adding Calendars to the store.~~ Fixed

Fixes T8224

Diff Detail

Repository

R9 Sink

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

rnicole requested review of this revision.Mar 27 2018, 9:56 AM

rnicole created this revision.

Switch to local CalDAV server for unit tests (currently has an auth fail when using Kube's container)
Add missing TypeHelper implementation (fixes the threadindexer warning, thanks Christian!)
Remove an unused variable due to removing the attachment field in the Event type

This revision was not accepted when it landed; it landed in state Needs Review.Mar 27 2018, 4:41 PM

Closed by commit R9:761328989492: Add CalDAV support (authored by rnicole, committed by cmollekopf). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		common/CMakeLists.txt (1 line)
M		common/domain/applicationdomaintype.h (24 lines)
M		common/domain/applicationdomaintype.cpp (10 lines)
M		common/domain/applicationdomaintype_p.h (2 lines)
A	M	common/domain/calendar.fbs (8 lines)
M		common/domain/event.fbs (3 lines)
M		common/domain/typeimplementations.h (12 lines)
M		common/domain/typeimplementations.cpp (25 lines)
M		examples/CMakeLists.txt (4 lines)
A	M	examples/caldavresource/CMakeLists.txt (15 lines)
P		examples/caldavresource/caldavresource.h (31 lines) Copied from examples/davresource/davresource.h
A	M	examples/caldavresource/caldavresource.cpp (155 lines)
A	M	examples/caldavresource/tests/CMakeLists.txt (9 lines)
A	M	examples/caldavresource/tests/caldavtest.cpp (93 lines)
V		examples/{carddavresource ← davresource}/CMakeLists.txt (6 lines)
V		examples/{carddavresource/carddavresource.h ← davresource/davresource.h} (16 lines)
A	M	examples/carddavresource/carddavresource.cpp (147 lines)
V		examples/{davresource → carddavresource}/CMakeLists.txt
P		examples/davresource/davresource.h Deleted after being copied to multiple locations: examples/caldavresource/caldavresource.h examples/carddavresource/carddavresource.h
D	M	examples/davresource/davresource.cpp (315 lines)
M		examples/dummyresource/resourcefactory.cpp (2 lines)
A	M	examples/webdavcommon/CMakeLists.txt (8 lines)
A	M	examples/webdavcommon/webdav.h (78 lines)
A	M	examples/webdavcommon/webdav.cpp (277 lines)
M		tests/CMakeLists.txt (1 line)
D	M	tests/calendar.fbs (12 lines)
M		tests/domainadaptortest.cpp (2 lines)
M		tests/storagebenchmark.cpp (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	30704			Mar 27 2018, 9:49 AM	★	★
Diff 2	30718			Mar 27 2018, 1:36 PM	★	★
Diff 3	30735	80afd70	R9:761328989492db9bd603c2d7f1134d20e485d2f6	Mar 27 2018, 4:26 PM	★	★