Feed Advanced Search

Jun 16 2019

fbampaloukas added a watcher for Sink: fbampaloukas.
Jun 16 2019, 9:30 AM

Jun 8 2019

bcooksley changed the edit policy for Sink.
Jun 8 2019, 9:03 PM

May 20 2019

cmollekopf triaged T10959: An error during changereplay will block all further changes from replay as Low priority.
May 20 2019, 6:14 AM · Sink

May 8 2019

rpatwal added a member for Sink: rpatwal.
May 8 2019, 10:48 AM

Apr 6 2019

rpatwal added a watcher for Sink: rpatwal.
Apr 6 2019, 4:41 PM

Jan 7 2019

cmollekopf moved T10288: Entity already in model: $id from New to Confirmed on the Kube: Bugs board.
Jan 7 2019, 9:57 PM · Kube: Bugs, Sink
cmollekopf triaged T10288: Entity already in model: $id as Normal priority.
Jan 7 2019, 9:50 PM · Kube: Bugs, Sink

Jan 5 2019

cmollekopf closed T9504: Date-range filtering for recurrences as Resolved.
Jan 5 2019, 7:57 PM · Kube (0.8), Sink

Jan 2 2019

cmollekopf triaged T10251: warning on removal in event.index.recurring as Normal priority.
Jan 2 2019, 8:26 PM · Sink

Dec 26 2018

cmollekopf closed T9533: The etag cache is not properly used for syncs as Resolved.

The etag cache is no more.

Dec 26 2018, 10:01 PM · Kube (0.8), Sink
cmollekopf closed T9754: Sink: failing to build develop branch as Resolved.

That's probably because you need kdav2 0.3. And cmake in sink should actually complain if that's not available.
Feel free to reopen if that was not it, but I'm sure the branch builds with the right dependencies.

Dec 26 2018, 10:00 PM · Sink

Nov 13 2018

jdb314 added a watcher for Sink: jdb314.
Nov 13 2018, 4:50 AM

Sep 26 2018

knambiar created T9754: Sink: failing to build develop branch.
Sep 26 2018, 9:47 AM · Sink

Sep 12 2018

cmollekopf triaged T9667: We sometimes duplicate the sent mail folder as Normal priority.
Sep 12 2018, 7:42 PM · Sink

Aug 30 2018

cmollekopf moved T9533: The etag cache is not properly used for syncs from Backlog to Done on the Kube (0.8) board.
Aug 30 2018, 7:28 AM · Kube (0.8), Sink

Aug 28 2018

cmollekopf moved T9504: Date-range filtering for recurrences from Backlog to Done on the Kube (0.8) board.
Aug 28 2018, 7:59 PM · Kube (0.8), Sink
cmollekopf edited projects for T9504: Date-range filtering for recurrences, added: Kube (0.8); removed Kube.
Aug 28 2018, 4:02 PM · Kube (0.8), Sink
cmollekopf edited projects for T9533: The etag cache is not properly used for syncs, added: Kube (0.8); removed Kube.
Aug 28 2018, 4:01 PM · Kube (0.8), Sink
cmollekopf triaged T9533: The etag cache is not properly used for syncs as Normal priority.
Aug 28 2018, 4:01 PM · Kube (0.8), Sink
cmollekopf triaged T9532: Large CalDAV fetches are slow as Normal priority.
Aug 28 2018, 4:00 PM · Sink, Kube

Aug 27 2018

cmollekopf added a comment to T9504: Date-range filtering for recurrences.

For the time being we're using the approach that sets dtend to the recurrence end (calculated for 10 years).
This seems to work well enough for the time being.

Aug 27 2018, 11:04 AM · Kube (0.8), Sink

Aug 26 2018

cmollekopf closed T2830: Use less space for UID and Revision, a subtask of T2797: Don't hardcode a revision number limit of 9999, as Resolved.
Aug 26 2018, 8:17 PM · Sink
cmollekopf closed T2830: Use less space for UID and Revision as Resolved.
Aug 26 2018, 8:17 PM · Sink
cmollekopf closed D15057: Fix some warnings.
Aug 26 2018, 3:36 PM · Sink
cmollekopf closed D15058: Optimize item fetching in DAV protocols.
Aug 26 2018, 3:19 PM · Sink
cmollekopf triaged T9510: Run simple functionality tests with actual webmail services in CI as Normal priority.
Aug 26 2018, 11:28 AM · Sink, Kube

Aug 25 2018

cmollekopf added a comment to T9504: Date-range filtering for recurrences.

An alternative approach would be to redefine dtstart as the end date of the overall recurrence.

Aug 25 2018, 7:42 AM · Kube (0.8), Sink
cmollekopf triaged T9504: Date-range filtering for recurrences as Normal priority.
Aug 25 2018, 7:40 AM · Kube (0.8), Sink

Aug 24 2018

cmollekopf closed T9490: Figure out how Google's CardDAV server works as Resolved by committing R864:bfe5e916e75c: Refresh collections individually if no CTag found.
Aug 24 2018, 2:14 PM · Sink
cmollekopf closed D15055: Refresh collections individually if no CTag found.
Aug 24 2018, 2:14 PM · KDE PIM, Sink
rnicole updated the summary of D15058: Optimize item fetching in DAV protocols.
Aug 24 2018, 2:07 PM · Sink
rnicole requested review of D15058: Optimize item fetching in DAV protocols.
Aug 24 2018, 2:06 PM · Sink
rnicole requested review of D15057: Fix some warnings.
Aug 24 2018, 2:04 PM · Sink
cmollekopf accepted D15055: Refresh collections individually if no CTag found.
Aug 24 2018, 12:28 PM · KDE PIM, Sink
rnicole updated the diff for D15055: Refresh collections individually if no CTag found.

Fix the usage of supportsPrincipals when I really wanted supportsCTags

Aug 24 2018, 12:21 PM · KDE PIM, Sink
rnicole added a revision to T9490: Figure out how Google's CardDAV server works: D15055: Refresh collections individually if no CTag found.
Aug 24 2018, 12:05 PM · Sink
rnicole requested review of D15055: Refresh collections individually if no CTag found.
Aug 24 2018, 12:05 PM · KDE PIM, Sink
rnicole added a comment to T9490: Figure out how Google's CardDAV server works.

I think I've found it. From the Google Contacts API, we find that the Home Set (/lists) contains all the other address books (/lists/default being one of them, but there can be more), but no contacts, so from my understanding, this is why the Home Set does not have any CTag. For some reason, it is also not possible to get the CTag of child collections from the /lists URL. I think the best solution is to refresh every collections individually in KDAV2 in the DavCollectionsFetchJob.

Aug 24 2018, 9:27 AM · Sink
rnicole added a comment to T9490: Figure out how Google's CardDAV server works.

No, we do have the Content-Type: text/xml; charset=utf-8 in KDav2 (Google apparently don't care if it's text/xml or application/xml, and from the XML RFC, the only difference between the two is human readability). The issue was more in the way I was testing from the command-line. The issue with Sink seems to be that Google can't find the getctag property (whereas it works from the command-line). This is weird since the propfind.xml is basically a copy paste from Sink's logs.

Aug 24 2018, 9:15 AM · Sink
cmollekopf added a comment to T9490: Figure out how Google's CardDAV server works.

looks like this is what the client is supposed to do anyways (http://sabre.io/dav/building-a-carddav-client/), so let's make sure that we have something like Content-Type: application/xml; charset=utf-8 in the request.
Is this perhaps something that we generally have missing in all requests in kdav2?

Aug 24 2018, 9:10 AM · Sink
rnicole added a comment to T9490: Figure out how Google's CardDAV server works.

Well, it seems that Google is completely ignoring the request if the Content-Type: application/xml is not present so adding -H "Content-Type: application/xml" to Curl's command line does the trick, and Google returns a valid CTag

Aug 24 2018, 9:03 AM · Sink
rnicole updated the task description for T9490: Figure out how Google's CardDAV server works.
Aug 24 2018, 8:57 AM · Sink
rnicole added a revision to T9490: Figure out how Google's CardDAV server works: D15001: Add CalDAV & CardDav URLs in "Google" account.
Aug 24 2018, 8:54 AM · Sink
rnicole created T9490: Figure out how Google's CardDAV server works.
Aug 24 2018, 8:54 AM · Sink

Aug 22 2018

cmollekopf closed D14974: Separate UIDs and Revisions in main databases.
Aug 22 2018, 1:03 PM · Sink
rnicole updated the diff for D14974: Separate UIDs and Revisions in main databases.
  • Fix model notifications by fixing the contains function
  • Add tests to the contains and exists functions from the Entity store
Aug 22 2018, 11:48 AM · Sink
rnicole updated the diff for D14974: Separate UIDs and Revisions in main databases.

Fix the testModifyWithConflict from pipelinetest by fixing the readRevisions function which was still using UIDs to access a main database. Now it uses the uidsToRevisions database.

Aug 22 2018, 9:22 AM · Sink
rnicole updated the diff for D14974: Separate UIDs and Revisions in main databases.
  • Fixed the random reading issues on database with integer keys with great help from Christian
  • Fixed the readPrevious function from the entity store
  • Fixed dumb issue in the size_t variant of the scan function
  • Add some storage tests
Aug 22 2018, 7:58 AM · Sink

Aug 21 2018

cmollekopf added inline comments to D14974: Separate UIDs and Revisions in main databases.
Aug 21 2018, 2:02 PM · Sink
rnicole requested review of D14974: Separate UIDs and Revisions in main databases.
Aug 21 2018, 12:56 PM · Sink

Aug 17 2018

cmollekopf closed T9437: carddavresource sync contacts, and then promptly removes them as Resolved.

It didn't take multiple collections into account.

Aug 17 2018, 8:51 PM · Sink
cmollekopf added a comment to T9437: carddavresource sync contacts, and then promptly removes them.
bash-4.4$ sinksh sync kolabnowCarddav
Log:     sinksh.store              : Synchronizing all resource matching:  Query [""] << Id: ""
  Filter: QHash()
  Ids: ("kolabnowCarddav")
  Sorting: ""
  Requested: ()
  Parent: ""
  IsLive: false
  ResourceFilter: Filter(QHash())
Aug 17 2018, 1:33 PM · Sink
cmollekopf closed T9435: deadlock in log.cpp as Resolved.
Aug 17 2018, 10:38 AM · Sink
cmollekopf triaged T9437: carddavresource sync contacts, and then promptly removes them as Normal priority.
Aug 17 2018, 10:38 AM · Sink
cmollekopf updated the task description for T9435: deadlock in log.cpp.
Aug 17 2018, 9:57 AM · Sink
cmollekopf triaged T9435: deadlock in log.cpp as Normal priority.
Aug 17 2018, 9:56 AM · Sink

Aug 6 2018

cmollekopf added a comment to T2830: Use less space for UID and Revision.

Binary UID is in, revision separation is WIP.

Aug 6 2018, 1:36 PM · Sink
cmollekopf closed T9258: mGenerator doens't seem to be used anymore in ResultSet as Resolved.
Aug 6 2018, 1:35 PM · Sink
cmollekopf closed T9261: Fulltext search does not consistently find what I would expect as Resolved.

Resolved by not limiting the search results as early as we used to.

Aug 6 2018, 1:32 PM · Sink
cmollekopf added a comment to T8555: [RFC] Import contacts from KDE Connect.

Sorry for the late reply, I have missed this ticket.

Aug 6 2018, 1:32 PM · KDE Connect, Sink
cmollekopf closed T9314: Deadlock in storage as Invalid.

This wasn't even the right backtrace.

Aug 6 2018, 1:23 PM · Sink
cmollekopf triaged T9314: Deadlock in storage as High priority.
Aug 6 2018, 1:22 PM · Sink

Aug 3 2018

cmollekopf closed D14547: Improve documentation of SinkSH.
Aug 3 2018, 3:11 PM · Sink
cmollekopf accepted D14547: Improve documentation of SinkSH.

Excellent, thanks =)

Aug 3 2018, 8:10 AM · Sink

Aug 2 2018

rnicole updated the diff for D14547: Improve documentation of SinkSH.

Put syntax and REGISTER_SYNTAX at the bottom

Aug 2 2018, 12:09 PM · Sink
cmollekopf added inline comments to D14547: Improve documentation of SinkSH.
Aug 2 2018, 11:27 AM · Sink
rnicole added inline comments to D14547: Improve documentation of SinkSH.
Aug 2 2018, 11:09 AM · Sink
cmollekopf added a comment to D14547: Improve documentation of SinkSH.

Looks great =)

Aug 2 2018, 9:54 AM · Sink
rnicole updated the summary of D14547: Improve documentation of SinkSH.
Aug 2 2018, 9:50 AM · Sink
rnicole updated the diff for D14547: Improve documentation of SinkSH.

Better explanation of the --reduce option in the list command

Aug 2 2018, 9:49 AM · Sink
rnicole requested review of D14547: Improve documentation of SinkSH.
Aug 2 2018, 8:49 AM · Sink

Jul 27 2018

cmollekopf closed D14404: Use Key API in SinkSH.
Jul 27 2018, 2:15 PM · Sink
cmollekopf closed D14289: Use Key API in ResultSet.
Jul 27 2018, 2:15 PM · Sink
cmollekopf closed D14099: Use Key API in DataStoreQuery.
Jul 27 2018, 2:15 PM · Sink
cmollekopf closed D13902: Use Key API in indexes.
Jul 27 2018, 2:15 PM · Sink
cmollekopf closed D13735: New Key API in storage layer.
Jul 27 2018, 2:15 PM · Sink
cmollekopf accepted D14404: Use Key API in SinkSH.
Jul 27 2018, 9:15 AM · Sink

Jul 26 2018

rnicole updated the summary of D14404: Use Key API in SinkSH.
Jul 26 2018, 3:03 PM · Sink
rnicole added a dependent revision for D14289: Use Key API in ResultSet: D14404: Use Key API in SinkSH.
Jul 26 2018, 3:02 PM · Sink
rnicole requested review of D14404: Use Key API in SinkSH.
Jul 26 2018, 3:02 PM · Sink

Jul 23 2018

cmollekopf accepted D14289: Use Key API in ResultSet.
Jul 23 2018, 2:13 PM · Sink
rnicole updated the diff for D14289: Use Key API in ResultSet.

Wrap assignment in lambda

Jul 23 2018, 2:10 PM · Sink
cmollekopf triaged T9261: Fulltext search does not consistently find what I would expect as Normal priority.
Jul 23 2018, 2:03 PM · Sink
cmollekopf added inline comments to D14289: Use Key API in ResultSet.
Jul 23 2018, 1:40 PM · Sink
rnicole updated the diff for D14289: Use Key API in ResultSet.

Make assignation clear.

Jul 23 2018, 12:27 PM · Sink
cmollekopf added inline comments to D14289: Use Key API in ResultSet.
Jul 23 2018, 10:10 AM · Sink
cmollekopf triaged T9258: mGenerator doens't seem to be used anymore in ResultSet as Normal priority.
Jul 23 2018, 10:01 AM · Sink
rnicole requested review of D14289: Use Key API in ResultSet.
Jul 23 2018, 9:18 AM · Sink
rnicole added a dependent revision for D14099: Use Key API in DataStoreQuery: D14289: Use Key API in ResultSet.
Jul 23 2018, 9:18 AM · Sink
cmollekopf accepted D14099: Use Key API in DataStoreQuery.
Jul 23 2018, 9:04 AM · Sink
cmollekopf added a comment to D14099: Use Key API in DataStoreQuery.

The benchmark tables are now updated, for some reason, memory went up in "Run benchmarks", but down in "Test Disk Usage"

Jul 23 2018, 9:04 AM · Sink
rnicole requested review of D14099: Use Key API in DataStoreQuery.

The benchmark tables are now updated, for some reason, memory went up in "Run benchmarks", but down in "Test Disk Usage"

Jul 23 2018, 8:49 AM · Sink
rnicole updated the summary of D14099: Use Key API in DataStoreQuery.
Jul 23 2018, 8:48 AM · Sink
rnicole updated the diff for D14099: Use Key API in DataStoreQuery.
  • Since Keys and Identifiers can now be "null", we can convert the selection part of the Reduce filter to use Identifiers
  • Also added the operator== and operator!= to Identifier, Revision and Key
  • Benchmark update coming up
Jul 23 2018, 8:40 AM · Sink

Jul 19 2018

cmollekopf accepted D14099: Use Key API in DataStoreQuery.
Jul 19 2018, 5:15 PM · Sink
rnicole updated the diff for D14099: Use Key API in DataStoreQuery.

Remove invalid comments about avoiding default construction

Jul 19 2018, 10:26 AM · Sink
rnicole updated the summary of D14099: Use Key API in DataStoreQuery.
Jul 19 2018, 8:57 AM · Sink
rnicole updated the diff for D14099: Use Key API in DataStoreQuery.
  • Default constructor of Identifier now produces null ids
  • Remove deprecation of Key's default constructor
  • Safety net: assert the uid is not null when converting to binary representation (when we pass it to the database)
Jul 19 2018, 8:10 AM · Sink

Jul 17 2018

cmollekopf added inline comments to D14099: Use Key API in DataStoreQuery.
Jul 17 2018, 8:16 AM · Sink

Jul 16 2018

rnicole updated the diff for D14099: Use Key API in DataStoreQuery.

Fix empty function

Jul 16 2018, 9:05 AM · Sink