rnicole (Rémi Nicole)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 19 2018, 9:46 AM (42 w, 2 d)
Availability
Available

Recent Activity

Aug 24 2018

rnicole updated the summary of D15058: Optimize item fetching in DAV protocols.
Aug 24 2018, 2:07 PM · Sink
rnicole requested review of D15058: Optimize item fetching in DAV protocols.
Aug 24 2018, 2:06 PM · Sink
rnicole requested review of D15057: Fix some warnings.
Aug 24 2018, 2:04 PM · Sink
rnicole updated the diff for D15055: Refresh collections individually if no CTag found.

Fix the usage of supportsPrincipals when I really wanted supportsCTags

Aug 24 2018, 12:21 PM · KDE PIM, Sink
rnicole added a revision to T9490: Figure out how Google's CardDAV server works: D15055: Refresh collections individually if no CTag found.
Aug 24 2018, 12:05 PM · Sink
rnicole requested review of D15055: Refresh collections individually if no CTag found.
Aug 24 2018, 12:05 PM · KDE PIM, Sink
rnicole added a comment to T9490: Figure out how Google's CardDAV server works.

I think I've found it. From the Google Contacts API, we find that the Home Set (/lists) contains all the other address books (/lists/default being one of them, but there can be more), but no contacts, so from my understanding, this is why the Home Set does not have any CTag. For some reason, it is also not possible to get the CTag of child collections from the /lists URL. I think the best solution is to refresh every collections individually in KDAV2 in the DavCollectionsFetchJob.

Aug 24 2018, 9:27 AM · Sink
rnicole added a comment to T9490: Figure out how Google's CardDAV server works.

No, we do have the Content-Type: text/xml; charset=utf-8 in KDav2 (Google apparently don't care if it's text/xml or application/xml, and from the XML RFC, the only difference between the two is human readability). The issue was more in the way I was testing from the command-line. The issue with Sink seems to be that Google can't find the getctag property (whereas it works from the command-line). This is weird since the propfind.xml is basically a copy paste from Sink's logs.

Aug 24 2018, 9:15 AM · Sink
rnicole added a comment to T9490: Figure out how Google's CardDAV server works.

Well, it seems that Google is completely ignoring the request if the Content-Type: application/xml is not present so adding -H "Content-Type: application/xml" to Curl's command line does the trick, and Google returns a valid CTag

Aug 24 2018, 9:03 AM · Sink
rnicole updated the task description for T9490: Figure out how Google's CardDAV server works.
Aug 24 2018, 8:57 AM · Sink
rnicole added a revision to T9490: Figure out how Google's CardDAV server works: D15001: Add CalDAV & CardDav URLs in "Google" account.
Aug 24 2018, 8:54 AM · Sink
rnicole added a task to D15001: Add CalDAV & CardDav URLs in "Google" account: T9490: Figure out how Google's CardDAV server works.
Aug 24 2018, 8:54 AM · Kube
rnicole created T9490: Figure out how Google's CardDAV server works.
Aug 24 2018, 8:54 AM · Sink

Aug 23 2018

rnicole updated the diff for D15001: Add CalDAV & CardDav URLs in "Google" account.

Revert and rename only in the UI

Aug 23 2018, 11:22 AM · Kube
rnicole updated the diff for D15001: Add CalDAV & CardDav URLs in "Google" account.

Renamed the "GMail" account to "Google". It seems that those who already have a Google account can remove their account from the command-line only, and then add it again from Kube

Aug 23 2018, 7:26 AM · Kube

Aug 22 2018

rnicole requested review of D15001: Add CalDAV & CardDav URLs in "Google" account.
Aug 22 2018, 2:21 PM · Kube
rnicole updated the diff for D14974: Separate UIDs and Revisions in main databases.
  • Fix model notifications by fixing the contains function
  • Add tests to the contains and exists functions from the Entity store
Aug 22 2018, 11:48 AM · Sink
rnicole updated the diff for D14974: Separate UIDs and Revisions in main databases.

Fix the testModifyWithConflict from pipelinetest by fixing the readRevisions function which was still using UIDs to access a main database. Now it uses the uidsToRevisions database.

Aug 22 2018, 9:22 AM · Sink
rnicole updated the diff for D14974: Separate UIDs and Revisions in main databases.
  • Fixed the random reading issues on database with integer keys with great help from Christian
  • Fixed the readPrevious function from the entity store
  • Fixed dumb issue in the size_t variant of the scan function
  • Add some storage tests
Aug 22 2018, 7:58 AM · Sink

Aug 21 2018

rnicole requested review of D14974: Separate UIDs and Revisions in main databases.
Aug 21 2018, 12:56 PM · Sink

Aug 2 2018

rnicole updated the diff for D14547: Improve documentation of SinkSH.

Put syntax and REGISTER_SYNTAX at the bottom

Aug 2 2018, 12:09 PM · Sink
rnicole added inline comments to D14547: Improve documentation of SinkSH.
Aug 2 2018, 11:09 AM · Sink
rnicole updated the summary of D14547: Improve documentation of SinkSH.
Aug 2 2018, 9:50 AM · Sink
rnicole updated the diff for D14547: Improve documentation of SinkSH.

Better explanation of the --reduce option in the list command

Aug 2 2018, 9:49 AM · Sink
rnicole requested review of D14547: Improve documentation of SinkSH.
Aug 2 2018, 8:49 AM · Sink

Jul 26 2018

rnicole updated the summary of D14404: Use Key API in SinkSH.
Jul 26 2018, 3:03 PM · Sink
rnicole added a dependent revision for D14289: Use Key API in ResultSet: D14404: Use Key API in SinkSH.
Jul 26 2018, 3:02 PM · Sink
rnicole requested review of D14404: Use Key API in SinkSH.
Jul 26 2018, 3:02 PM · Sink

Jul 23 2018

rnicole updated the diff for D14289: Use Key API in ResultSet.

Wrap assignment in lambda

Jul 23 2018, 2:10 PM · Sink
rnicole updated the diff for D14289: Use Key API in ResultSet.

Make assignation clear.

Jul 23 2018, 12:27 PM · Sink
rnicole requested review of D14289: Use Key API in ResultSet.
Jul 23 2018, 9:18 AM · Sink
rnicole added a dependent revision for D14099: Use Key API in DataStoreQuery: D14289: Use Key API in ResultSet.
Jul 23 2018, 9:18 AM · Sink
rnicole requested review of D14099: Use Key API in DataStoreQuery.

The benchmark tables are now updated, for some reason, memory went up in "Run benchmarks", but down in "Test Disk Usage"

Jul 23 2018, 8:49 AM · Sink
rnicole updated the summary of D14099: Use Key API in DataStoreQuery.
Jul 23 2018, 8:48 AM · Sink
rnicole updated the diff for D14099: Use Key API in DataStoreQuery.
  • Since Keys and Identifiers can now be "null", we can convert the selection part of the Reduce filter to use Identifiers
  • Also added the operator== and operator!= to Identifier, Revision and Key
  • Benchmark update coming up
Jul 23 2018, 8:40 AM · Sink

Jul 19 2018

rnicole updated the diff for D14099: Use Key API in DataStoreQuery.

Remove invalid comments about avoiding default construction

Jul 19 2018, 10:26 AM · Sink
rnicole updated the summary of D14099: Use Key API in DataStoreQuery.
Jul 19 2018, 8:57 AM · Sink
rnicole updated the diff for D14099: Use Key API in DataStoreQuery.
  • Default constructor of Identifier now produces null ids
  • Remove deprecation of Key's default constructor
  • Safety net: assert the uid is not null when converting to binary representation (when we pass it to the database)
Jul 19 2018, 8:10 AM · Sink

Jul 16 2018

rnicole updated the diff for D14099: Use Key API in DataStoreQuery.

Fix empty function

Jul 16 2018, 9:05 AM · Sink
rnicole added inline comments to D14099: Use Key API in DataStoreQuery.
Jul 16 2018, 8:58 AM · Sink

Jul 13 2018

rnicole added a dependent revision for D13902: Use Key API in indexes: D14099: Use Key API in DataStoreQuery.
Jul 13 2018, 4:11 PM · Sink
rnicole requested review of D14099: Use Key API in DataStoreQuery.
Jul 13 2018, 4:11 PM · Sink

Jul 10 2018

rnicole added a comment to D13902: Use Key API in indexes.

I'd say so too! But I'm still not sure why the disk statistics are so underwhelming :-/

Jul 10 2018, 2:02 PM · Sink
rnicole added a comment to D13902: Use Key API in indexes.

Results of the Dummy resource write benchmark:

Jul 10 2018, 1:24 PM · Sink
rnicole added a comment to D13902: Use Key API in indexes.

Some disk statistics:

Jul 10 2018, 11:33 AM · Sink

Jul 6 2018

rnicole updated the diff for D13902: Use Key API in indexes.

Increment database version

Jul 6 2018, 11:07 AM · Sink

Jul 5 2018

rnicole added a dependent revision for D13735: New Key API in storage layer: D13902: Use Key API in indexes.
Jul 5 2018, 1:44 PM · Sink
rnicole requested review of D13902: Use Key API in indexes.
Jul 5 2018, 1:44 PM · Sink

Jun 27 2018

rnicole updated the diff for D13735: New Key API in storage layer.
  • Use QUuid constructor instead of fromString
  • Remove useless comments
Jun 27 2018, 5:04 PM · Sink
rnicole updated the diff for D13735: New Key API in storage layer.
  • Fix pipeline test
  • Fix some issues with changereplay
Jun 27 2018, 10:16 AM · Sink

Jun 26 2018

rnicole added inline comments to D13735: New Key API in storage layer.
Jun 26 2018, 1:31 PM · Sink
rnicole added a comment to D13735: New Key API in storage layer.

Here are the result of a quick run of benchmarks (mailquerytest and pipelinetest) but I fear that there might not be enough samples for these to be statistically sound

Jun 26 2018, 12:28 PM · Sink
rnicole added a comment to D13477: Implement Overlap queries.
Jun 26 2018, 12:23 PM · Sink
rnicole added inline comments to D13735: New Key API in storage layer.
Jun 26 2018, 12:06 PM · Sink
rnicole added inline comments to D13735: New Key API in storage layer.
Jun 26 2018, 10:33 AM · Sink
rnicole added a comment to D13735: New Key API in storage layer.

I will probably move the Key / Identifier / Revision classes into entitystore since these are entity keys, etc.

Jun 26 2018, 10:17 AM · Sink
rnicole requested review of D13735: New Key API in storage layer.
Jun 26 2018, 10:09 AM · Sink

Jun 18 2018

rnicole added a comment to D13490: Use Overlap Sink query in PeriodDayEventModel.

They are used to partition the events into the right day of the week (like before)

Jun 18 2018, 11:01 AM · Kube
rnicole updated the diff for D13477: Implement Overlap queries.
  • Test live queries
  • Remove dates from the index (worst general case, but we're generally not the general case)
Jun 18 2018, 10:34 AM · Sink
rnicole planned changes to D13477: Implement Overlap queries.

Wait before merging it, storing the dates alongside the reference in the index is a "bad optimization" (changed my mind over the WE):

Jun 18 2018, 9:03 AM · Sink

Jun 12 2018

rnicole added a dependency for D13490: Use Overlap Sink query in PeriodDayEventModel: D13477: Implement Overlap queries.
Jun 12 2018, 7:51 AM · Kube
rnicole added a dependent revision for D13477: Implement Overlap queries: D13490: Use Overlap Sink query in PeriodDayEventModel.
Jun 12 2018, 7:51 AM · Sink
rnicole requested review of D13490: Use Overlap Sink query in PeriodDayEventModel.
Jun 12 2018, 7:49 AM · Kube

Jun 11 2018

rnicole requested review of D13477: Implement Overlap queries.
Jun 11 2018, 9:20 AM · Sink

May 25 2018

rnicole requested review of D13105: Implement ranged queries.
May 25 2018, 9:34 AM · Sink

May 24 2018

rnicole updated the diff for D13066: Add findAllInRange function in the storage layer.

Nitpicks

May 24 2018, 10:02 AM · Sink
rnicole updated the diff for D13066: Add findAllInRange function in the storage layer.

Remove the ahead-of-time finding of the closest key to the upper bound

May 24 2018, 9:55 AM · Sink

May 23 2018

rnicole requested review of D13066: Add findAllInRange function in the storage layer.
May 23 2018, 3:27 PM · Sink

May 22 2018

rnicole requested review of D13040: Add DavCollectionCreateJob and DavCollectionFetchJob .
May 22 2018, 1:55 PM · KDE PIM

May 17 2018

rnicole closed T8132: Attachements are not encrypted when sending encrypted messages as Resolved.

Correct! This is no longer the case

May 17 2018, 6:37 PM · Kube: Bugs

May 15 2018

rnicole updated the diff for D12875: Implement DayLongEventModel and integrate it to the calendar.

Register color in Kube.Colors
Follow attribute naming conventions

May 15 2018, 9:38 AM · Kube
rnicole added inline comments to D12875: Implement DayLongEventModel and integrate it to the calendar.
May 15 2018, 9:25 AM · Kube

May 14 2018

rnicole requested review of D12875: Implement DayLongEventModel and integrate it to the calendar.
May 14 2018, 2:38 PM · Kube
rnicole added a revision to T8697: Implement day-long event model: D12875: Implement DayLongEventModel and integrate it to the calendar.
May 14 2018, 2:38 PM · Kube (0.7)
rnicole added a revision to T8698: Add day-long property to the Event entity type: D12869: Add the "allDay" property to Event.
May 14 2018, 10:19 AM · Sink
rnicole requested review of D12869: Add the "allDay" property to Event.
May 14 2018, 10:19 AM · Sink
rnicole triaged T8698: Add day-long property to the Event entity type as Normal priority.
May 14 2018, 10:18 AM · Sink
rnicole triaged T8697: Implement day-long event model as Normal priority.
May 14 2018, 10:17 AM · Kube (0.7)
rnicole updated the diff for D12755: Fix CalDAV test in Docker + add Calendar and Todo in the database layout.

Rebase and remove useless testSyncCal

May 14 2018, 9:10 AM · Sink
rnicole added a comment to D12755: Fix CalDAV test in Docker + add Calendar and Todo in the database layout.

The testSyncCal's original purpose was:

May 14 2018, 9:03 AM · Sink
rnicole added inline comments to D12755: Fix CalDAV test in Docker + add Calendar and Todo in the database layout.
May 14 2018, 8:54 AM · Sink

May 8 2018

rnicole requested review of D12755: Fix CalDAV test in Docker + add Calendar and Todo in the database layout.
May 8 2018, 11:47 AM · Sink

May 4 2018

rnicole requested review of D12695: Implement Todo entity type.
May 4 2018, 11:07 AM · Sink

May 1 2018

rnicole updated the diff for D12611: Implement replaying CalDAV events and calendars.

Document test requirements

May 1 2018, 10:33 AM · Sink
rnicole added a comment to D12611: Implement replaying CalDAV events and calendars.

Oh right, I still haven't figured out how to configure Cyrus for CalDAV or how to add test data. My solution was to install a Radicale server, and add a MyCalendar with one event in it. I should have documented this in the test file, but I forgot. I'll fix that

May 1 2018, 10:28 AM · Sink
rnicole updated the diff for D12611: Implement replaying CalDAV events and calendars.
  • Remove useless comment
  • Return empty ID on event removal
May 1 2018, 7:47 AM · Sink

Apr 30 2018

rnicole requested review of D12611: Implement replaying CalDAV events and calendars.
Apr 30 2018, 12:56 PM · Sink

Apr 17 2018

rnicole updated the diff for D12280: Fix non-deterministic use after free in WebDAV.

Separate value extraction and processing

Apr 17 2018, 1:31 PM · Sink
rnicole requested review of D12280: Fix non-deterministic use after free in WebDAV.
Apr 17 2018, 12:33 PM · Sink
rnicole added inline comments to D12089: Implement EventTreeModel.
Apr 17 2018, 11:53 AM · Kube
rnicole updated the diff for D12089: Implement EventTreeModel.

Fix nitpicks

Apr 17 2018, 11:52 AM · Kube

Apr 16 2018

rnicole added inline comments to D12089: Implement EventTreeModel.
Apr 16 2018, 9:09 AM · Kube
rnicole updated the diff for D12089: Implement EventTreeModel.
  • Add period filtering (with start and length properties)
  • Rename EventTreeModel to PeriodDayEventModel (because it does the partitioning + filter according to a period)
Apr 16 2018, 9:09 AM · Kube

Apr 13 2018

rnicole updated the diff for D12106: Change most of Event's properties to extracted properties.

Removed some assertions and dynamic_cast a pointer instead of a reference

Apr 13 2018, 8:46 AM · Sink

Apr 11 2018

rnicole updated the diff for D12089: Implement EventTreeModel.
  • Fix copyright
  • Switch to live query
  • React to layoutChanged, rowsInserted / Moved / Removed, and modelReset signals from sink's model
  • Remove debug manual synchronization of sink store
  • Notify views with the modelReset signal
  • Get data from the store instead of test data
Apr 11 2018, 3:48 PM · Kube
rnicole updated the diff for D12087: Add calendar support in the Test Store.
  • Update to the adding of the Event preprocessor in Sink (T8485)
  • Set the resources correctly in the calendar view
Apr 11 2018, 3:07 PM · Kube
rnicole updated the diff for D12106: Change most of Event's properties to extracted properties.

Fixed the license header to display 2018 instead 2017
Add an assertion to check that the given iCal is valid in the Event property extractor

Apr 11 2018, 2:54 PM · Sink
rnicole requested review of D12106: Change most of Event's properties to extracted properties.
Apr 11 2018, 10:15 AM · Sink
rnicole added a revision to T8485: Change most of Event's properties to extracted properties: D12106: Change most of Event's properties to extracted properties.
Apr 11 2018, 10:15 AM · Sink
rnicole edited projects for T8485: Change most of Event's properties to extracted properties, added: Sink; removed Kube.
Apr 11 2018, 10:15 AM · Sink