rnicole (Rémi Nicole)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 19 2018, 9:46 AM (17 w, 5 d)
Availability
Available

Recent Activity

Mon, Jun 18

rnicole added a comment to D13490: Use Overlap Sink query in PeriodDayEventModel.

They are used to partition the events into the right day of the week (like before)

Mon, Jun 18, 11:01 AM · Kube
rnicole updated the diff for D13477: Implement Overlap queries.
  • Test live queries
  • Remove dates from the index (worst general case, but we're generally not the general case)
Mon, Jun 18, 10:34 AM · Sink
rnicole planned changes to D13477: Implement Overlap queries.

Wait before merging it, storing the dates alongside the reference in the index is a "bad optimization" (changed my mind this WE):

Mon, Jun 18, 9:03 AM · Sink

Tue, Jun 12

rnicole added a dependency for D13490: Use Overlap Sink query in PeriodDayEventModel: D13477: Implement Overlap queries.
Tue, Jun 12, 7:51 AM · Kube
rnicole added a dependent revision for D13477: Implement Overlap queries: D13490: Use Overlap Sink query in PeriodDayEventModel.
Tue, Jun 12, 7:51 AM · Sink
rnicole requested review of D13490: Use Overlap Sink query in PeriodDayEventModel.
Tue, Jun 12, 7:49 AM · Kube

Mon, Jun 11

rnicole requested review of D13477: Implement Overlap queries.
Mon, Jun 11, 9:20 AM · Sink

Fri, May 25

rnicole requested review of D13105: Implement ranged queries.
Fri, May 25, 9:34 AM · Sink

May 24 2018

rnicole updated the diff for D13066: Add findAllInRange function in the storage layer.

Nitpicks

May 24 2018, 10:02 AM · Sink
rnicole updated the diff for D13066: Add findAllInRange function in the storage layer.

Remove the ahead-of-time finding of the closest key to the upper bound

May 24 2018, 9:55 AM · Sink

May 23 2018

rnicole requested review of D13066: Add findAllInRange function in the storage layer.
May 23 2018, 3:27 PM · Sink

May 22 2018

rnicole requested review of D13040: Add DavCollectionCreateJob and DavCollectionFetchJob .
May 22 2018, 1:55 PM · KDE PIM

May 17 2018

rnicole closed T8132: Attachements are not encrypted when sending encrypted messages as Resolved.

Correct! This is no longer the case

May 17 2018, 6:37 PM · Kube: Bugs

May 15 2018

rnicole updated the diff for D12875: Implement DayLongEventModel and integrate it to the calendar.

Register color in Kube.Colors
Follow attribute naming conventions

May 15 2018, 9:38 AM · Kube
rnicole added inline comments to D12875: Implement DayLongEventModel and integrate it to the calendar.
May 15 2018, 9:25 AM · Kube

May 14 2018

rnicole requested review of D12875: Implement DayLongEventModel and integrate it to the calendar.
May 14 2018, 2:38 PM · Kube
rnicole added a revision to T8697: Implement day-long event model: D12875: Implement DayLongEventModel and integrate it to the calendar.
May 14 2018, 2:38 PM · Kube (0.7)
rnicole added a revision to T8698: Add day-long property to the Event entity type: D12869: Add the "allDay" property to Event.
May 14 2018, 10:19 AM · Sink
rnicole requested review of D12869: Add the "allDay" property to Event.
May 14 2018, 10:19 AM · Sink
rnicole triaged T8698: Add day-long property to the Event entity type as Normal priority.
May 14 2018, 10:18 AM · Sink
rnicole triaged T8697: Implement day-long event model as Normal priority.
May 14 2018, 10:17 AM · Kube (0.7)
rnicole updated the diff for D12755: Fix CalDAV test in Docker + add Calendar and Todo in the database layout.

Rebase and remove useless testSyncCal

May 14 2018, 9:10 AM · Sink
rnicole added a comment to D12755: Fix CalDAV test in Docker + add Calendar and Todo in the database layout.

The testSyncCal's original purpose was:

May 14 2018, 9:03 AM · Sink
rnicole added inline comments to D12755: Fix CalDAV test in Docker + add Calendar and Todo in the database layout.
May 14 2018, 8:54 AM · Sink

May 8 2018

rnicole requested review of D12755: Fix CalDAV test in Docker + add Calendar and Todo in the database layout.
May 8 2018, 11:47 AM · Sink

May 4 2018

rnicole requested review of D12695: Implement Todo entity type.
May 4 2018, 11:07 AM · Sink

May 1 2018

rnicole updated the diff for D12611: Implement replaying CalDAV events and calendars.

Document test requirements

May 1 2018, 10:33 AM · Sink
rnicole added a comment to D12611: Implement replaying CalDAV events and calendars.

Oh right, I still haven't figured out how to configure Cyrus for CalDAV or how to add test data. My solution was to install a Radicale server, and add a MyCalendar with one event in it. I should have documented this in the test file, but I forgot. I'll fix that

May 1 2018, 10:28 AM · Sink
rnicole updated the diff for D12611: Implement replaying CalDAV events and calendars.
  • Remove useless comment
  • Return empty ID on event removal
May 1 2018, 7:47 AM · Sink

Apr 30 2018

rnicole requested review of D12611: Implement replaying CalDAV events and calendars.
Apr 30 2018, 12:56 PM · Sink

Apr 17 2018

rnicole updated the diff for D12280: Fix non-deterministic use after free in WebDAV.

Separate value extraction and processing

Apr 17 2018, 1:31 PM · Sink
rnicole requested review of D12280: Fix non-deterministic use after free in WebDAV.
Apr 17 2018, 12:33 PM · Sink
rnicole added inline comments to D12089: Implement EventTreeModel.
Apr 17 2018, 11:53 AM · Kube
rnicole updated the diff for D12089: Implement EventTreeModel.

Fix nitpicks

Apr 17 2018, 11:52 AM · Kube

Apr 16 2018

rnicole added inline comments to D12089: Implement EventTreeModel.
Apr 16 2018, 9:09 AM · Kube
rnicole updated the diff for D12089: Implement EventTreeModel.
  • Add period filtering (with start and length properties)
  • Rename EventTreeModel to PeriodDayEventModel (because it does the partitioning + filter according to a period)
Apr 16 2018, 9:09 AM · Kube

Apr 13 2018

rnicole updated the diff for D12106: Change most of Event's properties to extracted properties.

Removed some assertions and dynamic_cast a pointer instead of a reference

Apr 13 2018, 8:46 AM · Sink

Apr 11 2018

rnicole updated the diff for D12089: Implement EventTreeModel.
  • Fix copyright
  • Switch to live query
  • React to layoutChanged, rowsInserted / Moved / Removed, and modelReset signals from sink's model
  • Remove debug manual synchronization of sink store
  • Notify views with the modelReset signal
  • Get data from the store instead of test data
Apr 11 2018, 3:48 PM · Kube
rnicole updated the diff for D12087: Add calendar support in the Test Store.
  • Update to the adding of the Event preprocessor in Sink (T8485)
  • Set the resources correctly in the calendar view
Apr 11 2018, 3:07 PM · Kube
rnicole updated the diff for D12106: Change most of Event's properties to extracted properties.

Fixed the license header to display 2018 instead 2017
Add an assertion to check that the given iCal is valid in the Event property extractor

Apr 11 2018, 2:54 PM · Sink
rnicole requested review of D12106: Change most of Event's properties to extracted properties.
Apr 11 2018, 10:15 AM · Sink
rnicole added a revision to T8485: Change most of Event's properties to extracted properties: D12106: Change most of Event's properties to extracted properties.
Apr 11 2018, 10:15 AM · Sink
rnicole edited projects for T8485: Change most of Event's properties to extracted properties, added: Sink; removed Kube.
Apr 11 2018, 10:15 AM · Sink
rnicole triaged T8485: Change most of Event's properties to extracted properties as Normal priority.
Apr 11 2018, 8:46 AM · Sink
rnicole added a comment to D12085: Add EndTime and Ical attributes to Event.

I'm confused, the properties are registered in applicationdomaintype.cpp (line 131-132)

Apr 11 2018, 8:34 AM · Sink

Apr 10 2018

rnicole requested review of D12089: Implement EventTreeModel.
Apr 10 2018, 2:24 PM · Kube
rnicole added a revision to T8225: Implement event models: D12089: Implement EventTreeModel.
Apr 10 2018, 2:24 PM · Kube
rnicole requested review of D12087: Add calendar support in the Test Store.
Apr 10 2018, 1:48 PM · Kube
rnicole added a revision to T8483: Add calendar support in the Test Store: D12087: Add calendar support in the Test Store.
Apr 10 2018, 1:48 PM · Kube
rnicole triaged T8483: Add calendar support in the Test Store as Normal priority.
Apr 10 2018, 1:44 PM · Kube
rnicole requested review of D12085: Add EndTime and Ical attributes to Event.
Apr 10 2018, 1:40 PM · Sink
rnicole added a revision to T8482: Add EndTime attribute to Event: D12085: Add EndTime and Ical attributes to Event.
Apr 10 2018, 1:40 PM · Sink
rnicole triaged T8482: Add EndTime attribute to Event as Normal priority.
Apr 10 2018, 1:08 PM · Sink

Apr 5 2018

rnicole added a comment to T8438: Missing file in Sink manual build?.

I think I've had this problem when enabling parallel building, it would sometimes compile files that uses thing_generated.h before it is created, but I haven't looked into it. Can you try building with 1 job, or building in parallel several times in a row?

Apr 5 2018, 11:51 AM · Kube: Bugs

Apr 3 2018

rnicole added a comment to T8120: Resource crash on connecting to Riseup SMTP server.

Right, sorry about that.

Apr 3 2018, 10:14 AM · Kube: Bugs

Mar 27 2018

rnicole updated the diff for D11741: Add CalDAV support.
  • Switch to local CalDAV server for unit tests (currently has an auth fail when using Kube's container)
  • Add missing TypeHelper implementation (fixes the threadindexer warning, thanks Christian!)
  • Remove an unused variable due to removing the attachment field in the Event type
Mar 27 2018, 1:41 PM · Sink
rnicole requested review of D11741: Add CalDAV support.
Mar 27 2018, 9:56 AM · Sink
rnicole added a revision to T8224: Implement CalDAV resource type: D11741: Add CalDAV support.
Mar 27 2018, 9:56 AM · Sink

Mar 15 2018

rnicole edited subtasks for T8093: Calendar UI, added: T8225: Implement event models; removed: T8224: Implement CalDAV resource type.
Mar 15 2018, 2:38 PM · Kube (0.7)
rnicole removed a parent task for T8224: Implement CalDAV resource type: T8093: Calendar UI.
Mar 15 2018, 2:38 PM · Sink
rnicole added a parent task for T8225: Implement event models: T8093: Calendar UI.
Mar 15 2018, 2:38 PM · Kube
rnicole added a subtask for T8225: Implement event models: T8224: Implement CalDAV resource type.
Mar 15 2018, 2:37 PM · Kube
rnicole added a parent task for T8224: Implement CalDAV resource type: T8225: Implement event models.
Mar 15 2018, 2:37 PM · Sink
rnicole triaged T8225: Implement event models as Normal priority.
Mar 15 2018, 2:37 PM · Kube
rnicole added a subtask for T8093: Calendar UI: T8224: Implement CalDAV resource type.
Mar 15 2018, 2:32 PM · Kube (0.7)
rnicole added a parent task for T8224: Implement CalDAV resource type: T8093: Calendar UI.
Mar 15 2018, 2:32 PM · Sink
rnicole closed T6995: Messageviewer: Option to import attached key as Resolved.
Mar 15 2018, 2:27 PM · Kube
rnicole closed T6995: Messageviewer: Option to import attached key, a subtask of T5914: GPG support, as Resolved.
Mar 15 2018, 2:27 PM · Kube
rnicole triaged T8224: Implement CalDAV resource type as Normal priority.
Mar 15 2018, 2:26 PM · Sink

Mar 12 2018

rnicole requested review of D11265: Fix expected-related OS X build failure.
Mar 12 2018, 4:26 PM · Kube
rnicole added a revision to T8185: OSX build failure: D11265: Fix expected-related OS X build failure.
Mar 12 2018, 4:26 PM · Kube: Bugs

Mar 9 2018

rnicole updated the diff for D11158: Automatic key import / export + Expected monad.

Add the License header to the errors.h file and elaborate on the "placement new" code.

Mar 9 2018, 10:36 AM · Kube

Mar 8 2018

rnicole closed T8112: Forwarding an encrypted mail will remain encrypted as Resolved.
Mar 8 2018, 4:29 PM · Kube: Bugs
rnicole closed T7024: Forward email as Resolved.
Mar 8 2018, 4:28 PM · Kube (0.6)
rnicole added a revision to T6995: Messageviewer: Option to import attached key: D11158: Automatic key import / export + Expected monad.
Mar 8 2018, 4:19 PM · Kube
rnicole added a task to D11158: Automatic key import / export + Expected monad: T6995: Messageviewer: Option to import attached key.
Mar 8 2018, 4:19 PM · Kube
rnicole added a comment to T8147: Email sent in both plain text and encrypted when choosing both "encrypt" and "sign".

This bug was fixed while re-writting the mailcrypto in the pkey import / export patch

Mar 8 2018, 4:18 PM · Kube: Bugs
rnicole added a revision to T8147: Email sent in both plain text and encrypted when choosing both "encrypt" and "sign": D11158: Automatic key import / export + Expected monad.
Mar 8 2018, 4:17 PM · Kube: Bugs
rnicole added a task to D11158: Automatic key import / export + Expected monad: T8147: Email sent in both plain text and encrypted when choosing both "encrypt" and "sign".
Mar 8 2018, 4:17 PM · Kube
rnicole added a revision to T6994: Composer: attach own key when sending a mail: D11158: Automatic key import / export + Expected monad.
Mar 8 2018, 4:16 PM · Kube (0.7)
rnicole added a task to D11158: Automatic key import / export + Expected monad: T6994: Composer: attach own key when sending a mail.
Mar 8 2018, 4:16 PM · Kube
rnicole requested review of D11158: Automatic key import / export + Expected monad.
Mar 8 2018, 4:16 PM · Kube
rnicole updated the diff for D10966: Support encrypted mails forwarding.

Rebase on develop because of merge conflict in "framework/src/domain/mime/mimetreeparser/tests/CMakeLists.txt"

Mar 8 2018, 11:08 AM · Kube (0.6)

Mar 5 2018

rnicole claimed T8147: Email sent in both plain text and encrypted when choosing both "encrypt" and "sign".
Mar 5 2018, 7:03 PM · Kube: Bugs
rnicole created T8147: Email sent in both plain text and encrypted when choosing both "encrypt" and "sign".
Mar 5 2018, 9:46 AM · Kube: Bugs

Mar 2 2018

rnicole updated the diff for D10966: Support encrypted mails forwarding.

Now works with messages that have attachments, and do the proper encoding.
Also, now with some tests

Mar 2 2018, 3:17 PM · Kube (0.6)
rnicole created T8132: Attachements are not encrypted when sending encrypted messages.
Mar 2 2018, 1:32 PM · Kube: Bugs
rnicole added tasks to D10966: Support encrypted mails forwarding: T8112: Forwarding an encrypted mail will remain encrypted, T7024: Forward email.
Mar 2 2018, 10:49 AM · Kube (0.6)
rnicole added a revision to T7024: Forward email: D10966: Support encrypted mails forwarding.
Mar 2 2018, 10:49 AM · Kube (0.6)
rnicole added a revision to T8112: Forwarding an encrypted mail will remain encrypted: D10966: Support encrypted mails forwarding.
Mar 2 2018, 10:49 AM · Kube: Bugs
rnicole requested review of D10966: Support encrypted mails forwarding.
Mar 2 2018, 10:49 AM · Kube (0.6)

Mar 1 2018

rnicole claimed T8112: Forwarding an encrypted mail will remain encrypted.
Mar 1 2018, 9:37 PM · Kube: Bugs
rnicole triaged T8120: Resource crash on connecting to Riseup SMTP server as Normal priority.
Mar 1 2018, 3:12 PM · Kube: Bugs

Feb 28 2018

rnicole moved T7735: Adressbook Rework from Backlog to In Progress on the Kube (0.6) board.
Feb 28 2018, 1:46 PM · Kube (0.6)
rnicole claimed T6995: Messageviewer: Option to import attached key.
Feb 28 2018, 9:02 AM · Kube
rnicole added a watcher for Kube: rnicole.
Feb 28 2018, 8:59 AM

Feb 27 2018

rnicole requested review of D10895: Add sanitizer support in CMake.
Feb 27 2018, 5:12 PM · Kube
rnicole requested review of D10891: Add Travis-CI integration.
Feb 27 2018, 3:22 PM · Kube

Feb 26 2018

rnicole requested review of D10861: Improvements of the log view.
Feb 26 2018, 1:56 PM

Feb 22 2018

rnicole requested review of D10740: Add some configuration files for code style tooling.
Feb 22 2018, 12:17 PM · Kube