to me the dataset description here is good, just the star numbers need to be changed to be better adapted to the actual difficulty of the levels.

Oh, looks like I missed this review request...
Actually I've added keyboard controls to this activity a few days ago and updated the manual accordingly, and fixed this part at the same time.
So this diff can be closed.

fixed in commit c1725fb7a9eb4255c1d597c40cdcd8cc4f804a25
closing as resolved.

fixed in commit bc5589c7e4c9630c7a8e9a85c5d01f3ae5539202
closing as resolved.

Like I said on the comment for multiplication memory:
-I think we should keep this content for the dataset
-just the text for the goals can be simplified (like, "subtraction table of 1, maximum number 11"...)
-and probably the difficulty/stars need to be adapted a bit

@dekumar:
I think the text can also be simplified for all the operations memory activities, similar to the enumeration memory, like:
"table of 1"
"table of 2"
...

No need to duplicate levels across datasets...
So only one level per dataset is enough (with one dataset per maximum number)

Maybe not in the introduction voices (as it would make them too long, and force to re-record specific voices for each arithmetic memory activity for all languages....).
But we could add such text note in the Manual parts, why not.

... same comment as for https://phabricator.kde.org/T13124.

I see what you mean, though as the description ("Goal" text) says, the goal is to "practice", which implies already learnt somehow...
So I would prefer to keep full table like this for the arithmetic memory activities, and not change the activity behavior.

Sounds good for me.
Just maybe, description can be a bit shorter, like
"match numbers up to 2" ...

@echarruau : this is the dataset content I asked for when reviewing the proposal: one dataset with one level per number table.

@echarruau : you put the link to this task in your comment, I guess you meant https://phabricator.kde.org/T12428
Also, the dataset description you put for "Addition and subtraction memory game against Tux" only contains addition related data, and too much redundant content...

I agree that if we want to add a way to choose the quantity representation, it should be with an activity option, not into the dataset.

Task completed in commit 9e7dd3355cc6008b7b29d2dc2a4b74c261fc3488 .

Good for me to merge now.

@echarruau : as I said before: I will redo the layout of the activity after the patch is pushed, to make sure it is optimized as much as possible in any case.

I think Dataset 3 and 4 (and maybe 2) should say "on multiple lines", not "on single line"...

Activity added in commit 3ef6576a028c79c6ba433a8ed3b148d8336fa251

I'll start working on this.

Fixed in commit 00a54ab5dba4b73b4838c5e5ce143e9e72abd79b
closing as Resolved.

After lot of thinking, I really think we should not do this.

The issue in Number sequence was fixed long ago now (commit a768009e5e0644410614ab677677bf57f056722e ).
The issue in enumerate was fixed in commit d5fd8e5239fd8cf72dbff1d793e99f3d3737172b.

Fixed in commit 71d07df9f12869be729ebb164c85e1f5fb79d22a
closing as resolved.

This was fixed in commit 6d3be37985f9b8e13fd9095c260903fa01ac0f33
closing as resolved.

Yes I said I was not sure I would need a variable, but actually as it will be a scaling depending on dataset content, it's better indeed to have a variable to define this mode within the dataset.

Yes it's better now, but it still has the exact same problem that you had with previous diff... please check again, and try to remember my comments on previous diff...