superbrain config changed to activityConfig multipledata style
ClosedPublic

Authored by dekumar on Apr 7 2020, 3:21 PM.

Diff Detail

Repository
R2 GCompris
Branch
superb_aconfig
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24920
Build 24938: arc lint + arc unit
dekumar created this revision.Apr 7 2020, 3:21 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 7 2020, 3:21 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
dekumar requested review of this revision.Apr 7 2020, 3:21 PM

Have you tried your changes?

Have you tried your changes?

I tested it works fine as expected. Is there any issue?

Have you tried your changes?

I tested it works fine as expected. Is there any issue?

Have you tried to change the configuration and see if it works as expected?

Have you tried your changes?

I tested it works fine as expected. Is there any issue?

Have you tried to change the configuration and see if it works as expected?

Yes, it works as expected.

Have you tried your changes?

I tested it works fine as expected. Is there any issue?

Have you tried to change the configuration and see if it works as expected?

I will check it again once as I think it works expected. But I will check again once to get sure.

Have you tried to change the configuration and see if it works as expected?

I will check it again once as I think it works expected. But I will check again once to get sure.

What is supposed to change when you change the mode?

dekumar updated this revision to Diff 79603.Apr 7 2020, 5:34 PM
  • Fixed minor issues

Have you tried to change the configuration and see if it works as expected?

I will check it again once as I think it works expected. But I will check again once to get sure.

What is supposed to change when you change the mode?

The mode needs to be changed from color to shape. As when the shape mode is selected there should be an option to play with shape and vice versa.

@jjazeix Sorry, I forgot to make some minor changes. Now it works fine as expected.

Yes it's better now, but it still has the exact same problem that you had with previous diff... please check again, and try to remember my comments on previous diff...

Yes it's better now, but it still has the exact same problem that you had with previous diff... please check again, and try to remember my comments on previous diff...

I remember that issue. I will fix it and update the diff.

dekumar updated this revision to Diff 79606.Apr 7 2020, 6:00 PM
  • Made requested chnages
This revision is now accepted and ready to land.Apr 7 2020, 6:55 PM
jjazeix closed this revision.Apr 7 2020, 6:56 PM