This implements the new method added in D26148 in the sftp/smb slaves.
Details
Details
Tested sftp locally with truncate. Seems to work.
Haven't tested locally with smb though.
Diff Detail
Diff Detail
- Repository
- R320 KIO Extras
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20218 Build 20236: arc lint + arc unit
sftp/kio_sftp.cpp | ||
---|---|---|
1492 | I wasn't too sure if attr was needed by libssh if the call succeeded. Looking at the source code it seems that you are probably right and can be freed in all circumstances. |
Comment Actions
I do wonder if maybe more granular return value handling of the smb truncate would be in order, but then I suppose the most relevant error is EACCES and that'd be handled at opening ¯\_(ツ)_/¯
LGTM
sftp/kio_sftp.cpp | ||
---|---|---|
1493 | I'd just get rid of the assignment TBH. The line below is the last place errorCode is used anyway, so the ternary could just move there. |