Require Qt 5.12 for QRegularExpression::achoredPattern()
Details
Details
- Reviewers
meven bruns astippich mlaurent apol dfaure - Group Reviewers
Baloo - Maniphest Tasks
- T12279: Port frameworks away from QRegExp
- Commits
- R293:eec35486c419: Port QRegExp to QRegularExpression
The code builds and unit tests pass.
Diff Detail
Diff Detail
- Repository
- R293 Baloo
- Branch
- l-qregexp (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20148 Build 20166: arc lint + arc unit
CMakeLists.txt | ||
---|---|---|
3 ↗ | (On Diff #71869) | We can't change qt version as it's a kf5 frameworks |
src/kioslaves/timeline/timelinetools.cpp | ||
---|---|---|
119 | Pleae avoid assigning in an if (...) expression, just move it to the previous line. |
src/kioslaves/timeline/timelinetools.cpp | ||
---|---|---|
122 | By moving this outside the else if above, we no longer go to the "else" branch on line 129 if the matching fails. @bruns I think this is actually a good use case for assigning inside an if () expression, as we already did in a number of other port-to-QRegularExpression commits. The alternative is helper functions or lambdas. |
Comment Actions
- Rebase
- Move second match inside if condition, otherwise the control flow never passes through the next else if branch