Like the existing F10 shortcut to create directories, this patch
adds a new shortcut to create files. The proposed default is Shift-F10.
Depends on D16412
FEATURE: 387762
Details
Details
- Reviewers
elvisangelaccio aacid - Group Reviewers
Dolphin Plasma VDG
Open Dolphin and hit Shift-F10.
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Branch
- arc_newfileshortcut (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 4186 Build 4204: arc lint + arc unit
| CMakeLists.txt | ||
|---|---|---|
| 11 | FYI: there is no time for KF5 5.52 (released on November 10th) in Applications 18.12 (dependency freeze is on November 8th). If you want to ship this feature with 18.12, we'll have to go with #ifdefs | |
| src/views/dolphinviewactionhandler.h | ||
| 103 | Please call it createFileTriggered() (I just pushed a patch that renames the createDirectory() signal). | |
| CMakeLists.txt | ||
|---|---|---|
| 11 | Than I think this can wait for 19.04. I will land this after 18.12 is released. | |
Comment Actions
I don't have an opinion about the new shortcut, I'll leave that to the VDG team.
| CMakeLists.txt | ||
|---|---|---|
| 11 | Please rebase, we are already depending on 5.53 now. | |
Comment Actions
I think this could make sense if you are also able to change the kind of file that you want to create.
Comment Actions
This patch (together with D16412) links the shortcut to the first entry in the Create New list, and that list can be modified by adding entries: https://j605.tk/blog/post/shorts/new-templates-in-dolphin/
It is a feature not easy to discover but it exists :) There are some bugs open to improve the situation: https://bugs.kde.org/show_bug.cgi?id=400263.
Comment Actions
I'm not super enthused about shift+F10 being the shortcut, but +1 on the feature!
What would be even better would be if the entire list were populated with keyboard shortcuts automatically, e.g. ctrl+shift+1, ctrl+shift+2, ctrl+shift+3, etc.
Comment Actions
@thsurrel are you planning to land this, or did you find my idea above so intriguing that you started to work on that instead? :)
Comment Actions
What is the status of this patch? Is it ready for committing, or are changes planned?
Comment Actions
This patch has to be reworked to implement Nate's idea, I am not totally sure how that will work though. I will need to modify KIO for that as well.
Comment Actions
If the patch has to be reworked let's mark it as such so it does not show in the "this is approved but not commited" list of reviews