Straight initial port of existing logic, with separate plugin metadata files
for different services. Perhaps could be changed to have just one normal
plugin, but with a config UI where the user can edit a list of
mediawiki-running servers and individual trigger words per server.
Left for another step/developer for now.
Details
A bug in Milou (kde #389611) prevents normal testing for now.
One can increase that reset timeout to some big value, e.g.
m_resetTimer.setInterval(3000);
in the Milou::SourcesModel constructor to work around the bug.
Then enable the mediawiki plugins you want to test, e.g. the
Wikipedia one, and enter in KRunner "wiki kde plasma"
Diff Detail
- Repository
- R114 Plasma Addons
- Branch
- portmediawiki
- Lint
No Linters Available - Unit
No Unit Test Coverage
Lgtm
runners/mediawiki/mediawiki.cpp | ||
---|---|---|
60–61 | Make sure to enable QNetworkAccessManager auto-redirect or else Ben will get mad at you | |
135 | Categorized logging, perhaps? | |
runners/mediawiki/mediawiki.h | ||
74–75 | Asterisk goes to variable name, QObject *parent (pedantic) | |
runners/mediawiki/plasma-runner-wikipedia.desktop | ||
118 | Is there a chance we can make this user-configurable or perhaps have it use the current language automatically? (Just asking, it's fine if you just did a straight port) |
Thanks for first round of review :)
runners/mediawiki/mediawiki.cpp | ||
---|---|---|
135 | Yes, though I plan to do this later in one concentrated go for all of kdeplasma-addons, so things will be consistent and complete. | |
runners/mediawiki/mediawiki.h | ||
74–75 | Ah, too much kdevelop code done (where asterisk goes to type) :) | |
runners/mediawiki/plasma-runner-wikipedia.desktop | ||
118 | No idea yet, but i had seen the related bug report https://bugs.kde.org/show_bug.cgi?id=256019 and agree that it will be good to have. I hope that can be covered in the planned follow-up work to improve the configuration UI to allow the user adding more mediawiki servers without having to create and install new desktop files like now. |