Revamp shortcut system
Closed, ResolvedPublic

Description

There are many problems with Krita's shortcuts as they currently stand. The 3.0 shift provides an opportunity to re-think the defaults, as well as alter the configuration system itself. This is a head task for several things that could help Krita's shortcut system become an asset instead of a liability.

Internal redesign.
The internals should be thoroughly refactored for Krita 3.0.
See T947.

Tool command subsystem.
This system is mostly separated from the QAction/KisAction part. We will leave it for later.
See T949.

Fix shortcut conflicts


Bugs
I did a search for the word "shortcut" in the KDE bug tracker. I found four general themes in the reports.

  • Design criteria
  • Layers shortcuts

A slew of uncategorized bugs - Please feel free to put these somewhere more useful!
https://bugs.kde.org/show_bug.cgi?id=344333
https://bugs.kde.org/show_bug.cgi?id=346111
https://bugs.kde.org/show_bug.cgi?id=342411
https://bugs.kde.org/show_bug.cgi?id=345226
https://bugs.kde.org/show_bug.cgi?id=332373
https://bugs.kde.org/show_bug.cgi?id=352747
https://bugs.kde.org/show_bug.cgi?id=349501
https://bugs.kde.org/show_bug.cgi?id=332526
https://bugs.kde.org/show_bug.cgi?id=340114
https://bugs.kde.org/show_bug.cgi?id=295151
https://bugs.kde.org/show_bug.cgi?id=332527
https://bugs.kde.org/show_bug.cgi?id=332540
https://bugs.kde.org/show_bug.cgi?id=328552
https://bugs.kde.org/show_bug.cgi?id=330197
https://bugs.kde.org/show_bug.cgi?id=322235
https://bugs.kde.org/show_bug.cgi?id=343401
https://bugs.kde.org/show_bug.cgi?id=345374
https://bugs.kde.org/show_bug.cgi?id=347620
https://bugs.kde.org/show_bug.cgi?id=331371
https://bugs.kde.org/show_bug.cgi?id=196620

abrahams updated the task description. (Show Details)
abrahams raised the priority of this task from to Normal.
abrahams added a project: Krita.
abrahams added subscribers: abrahams, rempt, woltherav.

There is a shortcut sheet downloadable: http://ghevan.deviantart.com/art/Krita-2-8-shortcuts-sheet-Dark-435305013 -- with a link from our website.

One of the reasons for forking xmlgui was so we could redo the shortcut system. It needs a real design, not just hacking though, because, as you say, we need to integrate both the canvas interaction shortcuts and the xmlgui shortcuts in one thing. And we need to solve the issue that shortcuts don't get loaded if the action is created later on.

I think we might take a look at how qt creator handles shortcuts. We should also add a list of all shortcut related bugs to this task and then do a bit of designing.

abrahams updated the task description. (Show Details)Oct 17 2015, 11:20 PM
abrahams raised the priority of this task from Normal to High.

I combed through some bug reports to add them to this task, and summarized our discussion on IRC in T947.

I'm adding another list of assorted bugs that looked relevant when I searched the "usability" and "general" sections, though I just copied the links and haven't categorized them. (Anyone else want to take a look? :D)

We should add more subtasks. I'll start with these:

  • Subtask for redesigning the defaults, to ask for input from users.
  • Subtask for fixing tool subsystem, since it needs to be refactored separately.
  • Subtask for layers shortcuts, since that is also relevant to the Kickstarter goal.
abrahams updated the task description. (Show Details)Oct 17 2015, 11:44 PM
abrahams updated the task description. (Show Details)Oct 18 2015, 12:23 AM
woltherav moved this task from Backlog to Krita Frameworks on the Krita board.Oct 28 2015, 7:07 PM

I don't know if this is the correct task to ask this question, but Is there a way to migrate and import the current (mostly custom) shortcut which the user may have set and got accustomed to from past versions of Krita. reassigning lot of them will be a hectic task ( although not much of a complain as it is one time thing while migrating to krita 3.0 shortcut system)

If you think this is not important or has been asked earlier or already done then please ignore this comment.

thank you

abrahams renamed this task from Krita shortcuts need to be reworked for 3.0 to Revamp shortcut system.Feb 11 2016, 7:20 PM
abrahams updated the task description. (Show Details)
abrahams updated the task description. (Show Details)
abrahams updated the task description. (Show Details)Feb 11 2016, 7:59 PM
abrahams removed abrahams as the assignee of this task.Mar 11 2016, 4:21 PM

After D1121 lands I do not intend to do any more significant refactoring before Krita 3.0 is released. The only big task remaining on my agenda is to restore checking for shortcut conflicts, which should be relatively straightforward.

Important work remaining seems to be re-considering the defaults, which will be done at the sprint, and updating the keyboard shortcut sheet, which will have to wait until afterward.

Things that are specific to my work should go in T1244, I'll place this task up for grabs and it can be closed if desired.

abrahams closed this task as Resolved.
abrahams claimed this task.