Move shortcut settings into "Configure Krita" menu

Authored by abrahams on Mar 11 2016, 3:54 PM.



This is desirable because it lessens the confusion of having "Canvas Input Settings" and "Shortcut Settings." Users can see at a glance that both pages are available. I think it looks nicer, too.

Class renaming and documentation updates can be done in a separate patch.

Diff Detail

R37 Krita
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
abrahams updated this revision to Diff 2709.Mar 11 2016, 3:54 PM
abrahams retitled this revision from to Move shortcut settings into "Configure Krita" menu.
abrahams updated this object.
abrahams edited the test plan for this revision. (Show Details)
abrahams added a reviewer: Krita.

It seems there's just one appropriate icon that has to be reused for "Shortcuts," "Performance" and "Canvas Input Settings." It would be nice to find a different icon for one of these.

abrahams updated this object.Mar 11 2016, 4:46 PM
dkazakov accepted this revision.Mar 13 2016, 7:29 PM
dkazakov added a reviewer: dkazakov.
dkazakov added a subscriber: dkazakov.

Hi, Michael!

Thank you for a nice patch! I'm perfectly ok with pushing it into master!

The only concern I have (probably unrelated to your patch) is the fact that the items in the settings dialog got sorted quite weirdly... Can you at least put the two shortcuts options near to each other somehow? Right now they are places in different parts of the dialog, which is extremely weird.

This revision is now accepted and ready to land.Mar 13 2016, 7:29 PM
This revision was automatically updated to reflect the committed changes.