We can simplify the AbstractWaylandOutput code some more by getting name and
refresh rate of an output from the always available output device object.
Details
Details
- Reviewers
- None
- Group Reviewers
KWin - Commits
- R108:e8fada8a36c4: Get name and refresh rate from output device
Tested with DRM, Wayland nested and virtual backends.
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Why does outputinterface and outputdevice interface have so much duped API?
KWayland is (at least sometimes) a lowlevel wrapper round the interfaces.
We have two interfaces because we wanted to extend wl_output, but also have a different lifespan on the protocol.
Comment Actions
Long term one could think of combining them such that WaylandOutput requires WaylandOutputDevice to exist and get its data directly from it in KWayland. Then we don't need the coupling done here in KWin.
On the other side someone might want to write a compositor without using WaylandOutputDevices. So there needs to be the independent API of WaylandOutput still available.