I found two places in plasma-framework svg.cpp (Plasma::Svg) that were triggering this message.
path variable was not being checked for empty before passing to QFile::exists().
This seems to be one source of the issue reported in Bug 388389
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Frameworks - Commits
- R242:5eece6769f21: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to…
Found that kicker was triggering this message and also plasmashell tooltips.
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Wonder if QFile really should be giving a warning if the path is empty instead of just returning false to be honest, but i'll leave it to the plasma devs to decide if they want this or if we should try to convince Qt to be less spammy
Comment Actions
There was a similar fix commited somewhere (don't remember, in KIO?) related to QFile in newer Qt complaining about empty filenames passed, so this is probably fine too...
Comment Actions
After reviewing the kio commit where similar changes were made, I changed QFile::exists to QFileInfo::exists as was done in kio and have updated my patch. I should have looked at kio before my first submission. Sorry.
Comment Actions
I'm new to phabricator and do not have commit access. Does someone need to commit this?