| dfaure |
| Frameworks |
CCBUG: 384561
Unfortunately, QDateTime::currentDateTime() checks /etc/localtime
each time it is called.
Chaning to QElapsedTime, no check of /etc/localtime.
Reproducing bug 384561, the strace of file.so was something like:
read(), stat(/etc/localtime), stat(/etc/localtime),
stat(/etc/localtime), stat(/etc/localtime), stat(/etc/localtime),
write(), read() ......
Now it is: read(), write()
It also reduces the cpu in io/wait around 10% in a debug build.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/core/slavebase.cpp | ||
|---|---|---|
| 117 ↗ | (On Diff #25242) | Init with 0 in the constructor? |
| src/core/slavebase.cpp | ||
|---|---|---|
| 117 ↗ | (On Diff #25242) | Could it be done without a review? I was busy doing arc land (with some problems) and I didn't notice. |
| src/core/slavebase.cpp | ||
|---|---|---|
| 117 ↗ | (On Diff #25242) | Sure |
Reverted in master as this broke various important ioslaves, like desktop and trash.
I believe the issue is that the timeout fires immediately after construction, without being configured by the slave.
I'm sorry for the inconvenience.
I'm going to divide the patch in two, the first part only changes lastTimeout and should be safe.
nextTimeout part needs more thinking (if can be done).