Differential D9675

Don't show context menu menu if right-clicking outside
ClosedPublic
Actions

Authored by broulik on Jan 5 2018, 10:19 AM.

Tags

Subscribers

elvisangelaccio, wbauer

Details

Reviewers

dfaure
mwolff

Group Reviewers

Commits

R263:5381b8b4b76c: Don't show context menu menu if right-clicking outside

Summary

BUG: 373653

When right-clicking a KXMLGui menu bar entry you can configure it.
The menu would also show up if right clicked outside the menu which is pointless as none of the actions in the menu would work as there's no action to configure to begin with.

Test Plan

Opened "File" menu, right-clicked on "Open", menu still showed up and I could configure the shortcut
Opened "File" menu, right-clicked outside menu, "File" menu just closed. Before I would still get a menu with none of its entries working

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik created this revision.Jan 5 2018, 10:19 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptJan 5 2018, 10:19 AM

broulik requested review of this revision.Jan 5 2018, 10:19 AM

Ping

I suppose that would fix https://bugs.kde.org/show_bug.cgi?id=373653 ?

In D9675#207283, @wbauer wrote:

I suppose that would fix https://bugs.kde.org/show_bug.cgi?id=373653 ?

Just tried it myself, and it does fix it.

ngraham edited the summary of this revision. (Show Details)Feb 15 2018, 10:05 PM

+1 works for me.

mwolff accepted this revision.Feb 26 2018, 1:56 PM

This revision is now accepted and ready to land.Feb 26 2018, 1:56 PM

Closed by commit R263:5381b8b4b76c: Don't show context menu menu if right-clicking outside (authored by broulik). · Explain WhyFeb 26 2018, 1:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/kmenumenuhandler_p.cpp (7 lines)

Diff 28107

src/kmenumenuhandler_p.cpp

Loading...