with 'KFilePlacesModel::movePlace' the external APIs can easily move
items in the model without replicate the code.
Depends on D8947
with 'KFilePlacesModel::movePlace' the external APIs can easily move
items in the model without replicate the code.
Depends on D8947
Unit test created
Lint Skipped |
Unit Tests Skipped |
src/filewidgets/kfileplacesmodel.h | ||
---|---|---|
80 ↗ | (On Diff #22741) | this doesn't match the names of the parameters, and use @p rather than single quotes. |
autotests/kfileplacesmodeltest.cpp | ||
---|---|---|
1039 ↗ | (On Diff #22783) | typo: position |
1041 ↗ | (On Diff #22783) | It was 0 already, so the TRY_ is unnecessary, if it's 0 it's ok right away, and if it's 1 then waiting more won't change it back to 0 ;) |
1045 ↗ | (On Diff #22783) | remove TRY_ |
src/filewidgets/kfileplacesmodel.cpp | ||
634 ↗ | (On Diff #22741) | why not just if (target > source) ? You're not using direction anywhere else. |
635 ↗ | (On Diff #22741) | Urgh, this shadows newTarget from the outer scope! |
636 ↗ | (On Diff #22741) | missing space after while (repeats) |
648 ↗ | (On Diff #22741) | typo: beginning |