Differential D8946

Avoid unnecessary 'dataChanged' signal
ClosedPublic
Actions

Authored by renatoo on Nov 22 2017, 2:18 PM.

Details

Reviewers
dfaure
Commits
R241:62c5d76f17a1: Avoid unnecessary 'dataChanged' signal
Summary

Only emit 'dataChanged' signal if the data really changes

Depends on D8945

Test Plan

Unit test created

Diff Detail

Repository
R241 KIO
Lint
Lint Skipped
Unit
Unit Tests Skipped
renatoo created this revision.Nov 22 2017, 2:18 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 22 2017, 2:18 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure accepted this revision.Nov 22 2017, 3:11 PM

Good stuff, it also skips a call to refresh() when nothing changed, which is good for performance.

This revision is now accepted and ready to land.Nov 22 2017, 3:11 PM
renatoo updated this revision to Diff 22758.Nov 22 2017, 5:24 PM

Updated parent branch

renatoo updated this revision to Diff 22769.Nov 22 2017, 5:58 PM

Updated parent branch

renatoo updated this revision to Diff 22781.Nov 22 2017, 7:15 PM

Updated from master

renatoo updated this revision to Diff 22816.Nov 23 2017, 11:54 AM

Parent branch updated

renatoo updated this revision to Diff 22954.Nov 26 2017, 1:26 PM

Updated parent branch

renatoo updated this revision to Diff 22965.Nov 26 2017, 3:25 PM

Updated parent branch

renatoo updated this revision to Diff 23012.Nov 27 2017, 1:22 PM

Updated parent branch

Closed by commit R241:62c5d76f17a1: Avoid unnecessary 'dataChanged' signal (authored by Renato Araujo Oliveira Filho <renato.araujo@kdab.com>). · Explain WhyNov 27 2017, 1:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22816

View Options

autotests/kfileplacesmodeltest.cpp

Loading...
View Options

src/filewidgets/kfileplacesmodel.cpp

Loading...